Refine syntax: expose overloaded inherited functions #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stcheng
approved these changes
Nov 9, 2017
rodnymolina
reviewed
Nov 9, 2017
| @@ -167,12 +167,11 @@ bool VlanMgr::removeHostVlanMember(int vlan_id, const string &port_alias) | |||
|
|
|||
| bool VlanMgr::isVlanMacOk() | |||
| { | |||
| return !(!gMacAddress); | |||
| return !!gMacAddress; | |||
There was a problem hiding this comment.
I know i'm late for this one, but i just noticed it now. Why would you change from the previous readable notation to this unintuitive one?
There was a problem hiding this comment.
Unnecessary parentheses make the previous code less readable, and less intuitive.
shine4chen
pushed a commit
to shine4chen/sonic-swss
that referenced
this pull request
Apr 30, 2019
[vxlanorch] * Adding the following logic: - When creating vxlan tunnel, create its bridge port. If VXLAN tunnel without bridge port, FDB MAC can not be learnt from or set to VXLAN tunnel in ASIC. - Add the tunnel name map to counter table, so that the ‘show mac’ command can display the FDB learnt from VXLAN tunnel. - Send command to Linux kernel to create L2 VXLAN tunnel interface. [fdborch] * FDB MAC can be learnt from or set to VXLAN tunnel in ASIC Signed-off-by: jianjun.dong <[email protected]>
shine4chen
pushed a commit
to shine4chen/sonic-swss
that referenced
this pull request
Apr 30, 2019
[vxlanorch] * Adding the following logic: - When creating vxlan tunnel, create its bridge port. If VXLAN tunnel without bridge port, FDB MAC can not be learnt from or set to VXLAN tunnel in ASIC. - Add the tunnel name map to counter table, so that the ‘show mac’ command can display the FDB learnt from VXLAN tunnel. - Send command to Linux kernel to create L2 VXLAN tunnel interface. [fdborch] * FDB MAC can be learnt from or set to VXLAN tunnel in ASIC Signed-off-by: jianjun.dong <[email protected]>
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
* Log message during stop/restart services during config load * Rethrow the exception, if caught
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.