Compile error in sonic-swss/orchagent/orchdaemon.cpp for 202205 branch

[vmittal-msft]

This is blocking new PRs - #2618
When i compile locally, it is fine. Only happening in PR Az pipeline.

[saiarcot895]

Recent runs in sonic-swss-common for the 202205 branch have been failing vstest (the deb packages are built, though). Because of this, azure pipeline is taking the artifacts from the most recent fully successful run, which is prior to sonic-net/sonic-swss-common@16ff689 (which the current version of sonic-swss 202205 branch needs).

There are two options here:

1. Revert 380f72b from the 202205 branch. This at least removes the dependency of the newer sonic-swss-common build needed to build the current sonic-swss. However, there may still be a vstest failure depending on what is causing the failure.
2. Allow azure pipeline to get artifacts even from partially successful/failed builds. Note that this may increase the number of pipeline failures for sonic-swss, even though the problem may be elsewhere. I have a draft PR for this at Clean up list of packages to install for pipeline build #2683. (EDIT: Looks like this actually won't work, this setting causes azure pipeline to consider using pipeline runs where everything fails, and when the needed artifact is missing, it errors out.)

[xumia]

For # 2, it may be a little aggressive to download the artifacts from the failed build. A PR #2685 to build the sonic-swss-common directly in sonic-swss, is it good for it? @saiarcot895 .

[saiarcot895]

Yeah that might be better, particularly if it doesn't take long to build it.