Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] fix binary_data_get unit test #841

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

Yakiv-Huryk
Copy link
Contributor

Fix incorrect sizeof() value in the Table.binary_data_get unit test

fix incorrect sizeof() value

Signed-off-by: Yakiv Huryk <[email protected]>
@prsunny
Copy link
Contributor

prsunny commented Dec 7, 2023

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Yakiv-Huryk
Copy link
Contributor Author

/azp run

Copy link

Commenter does not have sufficient privileges for PR 841 in repo sonic-net/sonic-swss-common

@Yakiv-Huryk
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik
Copy link
Collaborator

@prsunny can you please merge?

@prsunny
Copy link
Contributor

prsunny commented Dec 18, 2023

@qiluo-msft to merge

@Junchao-Mellanox
Copy link
Collaborator

Hi @qiluo-msft ,

This is a blocking issue for bookworm. I see following error in my local build:

11:34:33  /usr/include/c++/12/bits/basic_string.h:620:21: error: array subscript 8 is outside array bounds of 'const char [6]' [-Werror=array-bounds]
11:34:33    620 |         _M_construct(__s, __s + __n, std::forward_iterator_tag());
11:34:33        |         ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
11:34:33  In constructor 'std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::basic_string(const _CharT*, size_type, const _Alloc&) [with _CharT = char; _Traits = std::char_traits<char>; _Alloc = std::allocator<char>]',
11:34:33      inlined from 'virtual void Table_binary_data_get_Test::TestBody()' at tests/redis_ut.cpp:857:53:
11:34:33  /usr/include/c++/12/bits/basic_string.h:620:21: error: array subscript 8 is outside array bounds of 'const char [6]' [-Werror=array-bounds]
11:34:33    620 |         _M_construct(__s, __s + __n, std::forward_iterator_tag());
11:34:33        |         ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Could you please help merge it if no more comments?

@ganglyu ganglyu merged commit 16bc247 into sonic-net:master Jan 10, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants