From ec9082eda9f3fd3c80e01ff3853653a273ee96e2 Mon Sep 17 00:00:00 2001 From: Joe LeVeque Date: Wed, 14 Oct 2020 11:10:40 -0700 Subject: [PATCH] [ChassisBase][ModuleBase] Remove redundant 'get_serial_number()' method (#130) ChassisBase and ModuleBase inherit from the DeviceBase class, which already provides a get_serial() method. Thus, these methods were redundant. --- sonic_platform_base/chassis_base.py | 9 --------- sonic_platform_base/module_base.py | 9 --------- 2 files changed, 18 deletions(-) diff --git a/sonic_platform_base/chassis_base.py b/sonic_platform_base/chassis_base.py index 9d4263d20..01019cb33 100644 --- a/sonic_platform_base/chassis_base.py +++ b/sonic_platform_base/chassis_base.py @@ -82,15 +82,6 @@ def get_base_mac(self): """ raise NotImplementedError - def get_serial_number(self): - """ - Retrieves the hardware serial number for the chassis - - Returns: - A string containing the hardware serial number for this chassis. - """ - raise NotImplementedError - def get_system_eeprom_info(self): """ Retrieves the full content of system EEPROM information for the chassis diff --git a/sonic_platform_base/module_base.py b/sonic_platform_base/module_base.py index 6a7d2a7d5..ecfe09804 100644 --- a/sonic_platform_base/module_base.py +++ b/sonic_platform_base/module_base.py @@ -54,15 +54,6 @@ def get_base_mac(self): """ raise NotImplementedError - def get_serial_number(self): - """ - Retrieves the hardware serial number for the module - - Returns: - A string containing the hardware serial number for this module. - """ - raise NotImplementedError - def get_system_eeprom_info(self): """ Retrieves the full content of system EEPROM information for the module