Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
It's found that the PC test_lag_2 tests could fail on common_setup_teardown. This routine is using parallel thread to do config_reload. The parallel thread is by default has pool of 2 threads. The config_reload() has some changes to wait 900 seconds if safe_reload flag is not set. This has 2 issues here.
Fix is for PC common_setup_teardown to use thread pool and set number of hosts as number of threads. Thus all cards will execute config_reload at the same time.
Also when calling config_reload() set safe_reload to be true.
Summary:
Fixes # (issue)
Type of change
Back port request
How did you verify/test it?
Verified on OC test bed with the fix. Test passed.