Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PC test_lag_2 failure issue #15780

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

wumiaont
Copy link
Contributor

Description of PR

It's found that the PC test_lag_2 tests could fail on common_setup_teardown. This routine is using parallel thread to do config_reload. The parallel thread is by default has pool of 2 threads. The config_reload() has some changes to wait 900 seconds if safe_reload flag is not set. This has 2 issues here.

  1. With 2 threads pool and we have 4 cards on testing bed, will have 2 cards doing config_reload and after that's done another 2 will have change to run. This could make total wait time have to be set to > 30 min. Currently wait time is 10m.
  2. Set config_reload to be true will save many times to check if all critical services are back on line than config_reload to be false which will make API wait 15m before quit

Fix is for PC common_setup_teardown to use thread pool and set number of hosts as number of threads. Thus all cards will execute config_reload at the same time.
Also when calling config_reload() set safe_reload to be true.

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

How did you verify/test it?

Verified on OC test bed with the fix. Test passed.

@auspham
Copy link
Contributor

auspham commented Nov 27, 2024

Hi @wumiaont, i have raised a PR here for this #15721

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants