sonic-mgmt / IXIA : T2 test to verify ECN Counter operation pre and post port state toggle

[sreejithsreekumaran]

Description of PR

Summary:
Fixes # (issue)

Type of change

• Bug fix
• Testbed and Framework(new/improvement)
• Test case(new/improvement)

Back port request

• 202012
• 202205
• 202305
• 202311
• 202405

Approach

What is the motivation for this PR?

MIGSMSFT-630 Add sonic-mgmt / IXIA test for cisco platforms to verify ECN Counter operation.

How did you do it?

Create two flows one for each lossless TC per Ixia port each at half of 99.98% rate

• Inject traffic and read ECN Counters and verify it incremented.

• flap the interface state (shut, wait for 0.2 seconds, no shut the interfaces of Ixia)

• restart the traffic streams

• verify that the ECN counters increment from the baseline value (new values read MUST NOT be zero)

How did you verify/test it?

Verified on T2 DUT setup

============================================================================================================================================ PASSES =============================================================================================================================================
____________________________________________________________________________________________________________ test_ecn_marking_port_toggle[multidut_port_keys=single-dut-multi-asic] _____________________________________________________________________________________________________________
____________________________________________________________________________________________________________ test_ecn_marking_port_toggle[multidut_port_keys=single-dut-single-asic] ____________________________________________________________________________________________________________
---------------------------------------------------------------------------------------------------- generated xml file: /run_logs/ixia/17467/2024-11-15-16-20-28/tr_2024-11-15-16-20-28.xml ----------------------------------------------------------------------------------------------------
INFO:root:Can not get Allure report URL. Please check logs
------------------------------------------------------------------------------------------------------------------------------------ live log sessionfinish -------------------------------------------------------------------------------------------------------------------------------------
16:34:46 __init__.pytest_terminal_summary         L0067 INFO   | Can not get Allure report URL. Please check logs
==================================================================================================================================== short test summary info ====================================================================================================================================
PASSED snappi_tests/multidut/ecn/test_multidut_ecn_marking_with_snappi.py::test_ecn_marking_port_toggle[multidut_port_keys=single-dut-multi-asic]
PASSED snappi_tests/multidut/ecn/test_multidut_ecn_marking_with_snappi.py::test_ecn_marking_port_toggle[multidut_port_keys=single-dut-single-asic]
=========================================================================================================================== 2 passed, 5 warnings in 856.18s (0:14:16) ==========================================================================================================================

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

[sreejithsreekumaran]

@rraghav-cisco @abdosi @sdszhang

[sdszhang]

@abdosi can you help to review this one? Thanks.

[sdszhang]

is flow3_ecn > 0 enough? Do we expect a percentage of packets to be marked?

[sreejithsreekumaran]

In this specific port toggle test case, we are only making sure the ECN marking is happening.

We will have separate test to check the percentage of marking probably based on DWRR.

[abdosi]

@sreejithsreekumaran : please resolve conflict.

[mssonicbld]

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/snappi_tests/multidut/ecn/files/multidut_helper.py:74:1: E302 expected 2 blank lines, found 1
tests/snappi_tests/multidut/ecn/files/multidut_helper.py:150:1: E302 expected 2 blank lines, found 1
tests/snappi_tests/multidut/ecn/files/multidut_helper.py:311:1: E302 expected 2 blank lines, found 1
tests/snappi_tests/multidut/ecn/files/multidut_helper.py:330:1: F811 redefinition of unused 'toggle_dut_port_state' from line 311
tests/snappi_tests/multidut/ecn/files/multidut_helper.py:330:1: E302 expected 2 blank lines, found 1
tests/snappi_tests/multidut/ecn/files/multidut_helper.py:509:1: E302 expected 2 blank lines, found 1

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
   the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
   docker container.
2. Ensure that the pre-commit package is installed:

sudo pip install pre-commit

3. Go to repository root folder
4. Install the pre-commit hooks:

pre-commit install

5. Use pre-commit to check staged file:

pre-commit

6. Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

[mssonicbld]

@sreejithsreekumaran PR conflicts with 202405 branch

[mssonicbld]

Cherry-pick PR to 202405: #15763