Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sflow + dropmon] added patches for the sFlow + dropmon feature. #276

Merged
merged 2 commits into from
Apr 20, 2022

Conversation

vadymhlushko-mlnx
Copy link
Contributor

@vadymhlushko-mlnx vadymhlushko-mlnx commented Mar 28, 2022

Why I did it

sFlow + dropmon feature require the patches provided by SDK team Mellanox/Switch-SDK-drivers/tree/sx_sdk_4_5_1200_4.5.1208/kernel_backports/5.10.0

How I did it

Added patches.

@saiarcot895
Copy link
Contributor

A few comments:

  1. Split the patch you have into two (or more) different patches: one that is backported from upstream (with the commit ID included in the patch), and one that includes any custom changes.
  2. In each patch file, describe what changes are being done, with a useful subject line.
  3. Is there a reason that the patch has to be conditionally included here, and why it can't be included always?

@vadymhlushko-mlnx
Copy link
Contributor Author

A few comments:

  1. Split the patch you have into two (or more) different patches: one that is backported from upstream (with the commit ID included in the patch), and one that includes any custom changes.
  2. In each patch file, describe what changes are being done, with a useful subject line.
  3. Is there a reason that the patch has to be conditionally included here, and why it can't be included always?

Fixed, could you please review

@liat-grozovik
Copy link
Collaborator

@saiarcot895 kindly reminder to review the changes following comments provided.

struct rcu_head rcu;
};

+#define PSAMPLE_MD_EXTENDED_ATTR 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it was never used - deleted patch

@saiarcot895
Copy link
Contributor

Please add the upstream commit ID in the description for 0001-psample-Encapsulate-packet-metadata-in-a-struct.patch and 0002-psample-Add-additional-metadata-attributes.patch.

…added upstream commit id to description

Signed-off-by: Vadym Hlushko <[email protected]>
@vadymhlushko-mlnx
Copy link
Contributor Author

Please add the upstream commit ID in the description for 0001-psample-Encapsulate-packet-metadata-in-a-struct.patch and 0002-psample-Add-additional-metadata-attributes.patch.

Fixed

@saiarcot895
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@saiarcot895 saiarcot895 merged commit 1f83896 into sonic-net:master Apr 20, 2022
dprital added a commit to dprital/sonic-buildimage that referenced this pull request Aug 9, 2022
Update sonic-linux-kernel submodule pointer to include the following:
* [Mellanox] Add new kernel patches from HW-MGMT package V.7.0020.3005 ([sonic-net#287](sonic-net/sonic-linux-kernel#287))
* [patch] mlxsw: i2c: Prevent transaction execution for special chip ([sonic-net#279](sonic-net/sonic-linux-kernel#279))
* [sflow + dropmon] added missing patch for the sFlow + dropmon feature. ([sonic-net#281](sonic-net/sonic-linux-kernel#281))
* [sflow + dropmon] added patches for the sFlow + dropmon feature. ([sonic-net#276](sonic-net/sonic-linux-kernel#276))

Signed-off-by: dprital <[email protected]>
vadymhlushko-mlnx added a commit to vadymhlushko-mlnx/sonic-linux-kernel that referenced this pull request Aug 15, 2022
…ic-net#276)

* [sflow + dropmon] added patches for the sFlow dropmon feature

Signed-off-by: Vadym Hlushko <[email protected]>

* [sflow + dropmon] fixed review comments - removed unnecessary patch, added upstream commit id to description

Signed-off-by: Vadym Hlushko <[email protected]>
vadymhlushko-mlnx added a commit to vadymhlushko-mlnx/sonic-linux-kernel that referenced this pull request Aug 16, 2022
…ic-net#276)

* [sflow + dropmon] added patches for the sFlow dropmon feature

Signed-off-by: Vadym Hlushko <[email protected]>

* [sflow + dropmon] fixed review comments - removed unnecessary patch, added upstream commit id to description

Signed-off-by: Vadym Hlushko <[email protected]>
vadymhlushko-mlnx added a commit to vadymhlushko-mlnx/sonic-linux-kernel that referenced this pull request Aug 16, 2022
…ic-net#276)

* [sflow + dropmon] added patches for the sFlow dropmon feature

Signed-off-by: Vadym Hlushko <[email protected]>

* [sflow + dropmon] fixed review comments - removed unnecessary patch, added upstream commit id to description

Signed-off-by: Vadym Hlushko <[email protected]>
yxieca pushed a commit that referenced this pull request Aug 29, 2022
* [sflow + dropmon] added patches for the sFlow dropmon feature

Signed-off-by: Vadym Hlushko <[email protected]>

* [sflow + dropmon] fixed review comments - removed unnecessary patch, added upstream commit id to description

Signed-off-by: Vadym Hlushko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants