Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ConfigDB] Move all BGP configuration into DB #861

Merged
merged 5 commits into from
Aug 8, 2017
Merged

[ConfigDB] Move all BGP configuration into DB #861

merged 5 commits into from
Aug 8, 2017

Conversation

taoyl-ms
Copy link
Contributor

@taoyl-ms taoyl-ms commented Aug 2, 2017

  • BGP data read from minigraph.py now match DB schema
  • BGP templates are updated
  • bgpcfgd can now deal with runtime neighbor create/delete

lguohan
lguohan reviewed Aug 7, 2017
View reviewed changes
files/image_config/platform/rc.local Outdated
@@ -35,8 +35,18 @@ if [ -f /host/image-$sonic_version/platform/firsttime ]; then
mv -f /host/old_config/* /etc/sonic/
elif [ -f /host/minigraph.xml ]; then
mv /host/minigraph.xml /etc/sonic/
if [ -f /etc/sonic/init_cfg.json ]; then
Copy link
Collaborator

@lguohan lguohan Aug 7, 2017 •
edited by taoyl-ms
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if [ -f /etc/sonic/init_cfg.json ]; then [](start = 8, length = 40)

add some comment for TODO. For example, currently we still load minigraph using -m, we need to remove it in the future. #Resolved

lguohan
lguohan reviewed Aug 8, 2017
View reviewed changes
src/sonic-config-engine/minigraph.py Outdated
'peer_addr': end_peer
})
Copy link
Collaborator

@lguohan lguohan Aug 8, 2017 •
edited by taoyl-ms
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here, should we change the 'peer_addr' -> 'addr', and 'name' -> 'peer_name'?

this is because, the end_router is myself, and the name is really the my peer name. #WontFix

Copy link
Contributor Author

@taoyl-ms taoyl-ms Aug 8, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the table name is "BGP_NEIGHBOR", I think it is pretty straight forward that "name" here is the name of bgp neighbor. "peer_addr" does sound a bit confusing, I'll suggest we can change it into "local_addr". What's your suggestion? #Closed

lguohan
lguohan requested changes Aug 8, 2017
View reviewed changes
Copy link
Collaborator

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change 'name' to 'peer_name' for bgp neighbor table schema.

@taoyl-ms taoyl-ms merged commit a2fe021 into sonic-net:master Aug 8, 2017
zhenggen-xu pushed a commit to zhenggen-xu/sonic-buildimage that referenced this pull request Oct 17, 2019
Merge remote-tracking branch 'msft_github/master'
05dcbeb 
* msft_github/master:
  [docker-fpm-quagga]: Manage Quagga processes (zebra, bgpd) using supervisor instead of watchquagga (sonic-net#900)
  Add arista-net initramfs hook (sonic-net#899)
  Add Marvell platform (sonic-net#765)
  [sonic-utilities]: Update submodule to remove pager from CLI utils (sonic-net#897)
  Fixing a couple of issues to enable FRR to run with latest SONiC code. (sonic-net#895)
  Fix the network command for ipv6 vlan interfaces (sonic-net#894)
  Add s8810 32q platform support (sonic-net#867)
  [quagga]: Update sonic-quagga submodule (sonic-net#892)
  [docker-database]: Start rsyslogd to allow supervisor to log to syslog (sonic-net#890)
  [docker-platform-monitor]: Prevent supervisor from logging unexpected exits from processes known to exit in < 1 second (sonic-net#889)
  Update sonic-utilities (sonic-net#887)
  [submodule] update sonic-swss submodule (sonic-net#885)
  [LEDs]: Initialize status and fan LEDs to green on Arista 7050-QX-32/7050-QX-32-S (sonic-net#886)
  [sfputil]: Add support for SFP presence, low-power mode and reset (sonic-net#877)
  [System logs]: Improvements to prevent filling /var/log partition (sonic-net#865)
  Update sonic-utilities pointer to support reload minigraph (sonic-net#871)
  [device/accton]: Update Accton-AS7712-32X (sonic-net#776)
  [ConfigDB] Move all BGP configuration into DB (sonic-net#861)
  [sonic-slave]: Split user commands from generic. (sonic-net#868)
  [platform] Add support for Arista DCS-7260CX3-64 (sonic-net#863)
abdosi added a commit to abdosi/sonic-buildimage that referenced this pull request May 14, 2020
@abdosi
[Submodule update] sonic-utilities
4a74166 
Fix is_mgmt_vrf_enabled when MGMT_VRF_CONFIG is not present the config (sonic-net#885)
Changes to support acl-loader command for multi-npu platforms. (sonic-net#908)
Stop/Start restapi server upon config reload (sonic-net#911)
[fanshow] Add column drawer name and led status to output of show
platform(sonic-net#991)
[MultiDB] use sonic-db-cli instead of redis-cli in new added codes
(sonic-net#907)
[show] Add `ntpstat` output to `show ntp` (sonic-net#861)
[config] Log invocation of config commands to syslog (sonic-net#259)
Remove dependency on click-default-group package (sonic-net#903)
[config] Add 'interface transceiver' subgroup with 'lpmode' and 'rese…'
(sonic-net#904)
[show] Add 'errors' and 'rates' subcommands to 'show interfaces
count…(sonic-net#900)
[config] Support load_minigraph command for multi NPU platform (sonic-net#896)
[Vnet] Fix NameError for 'swsssdk' and align output (sonic-net#902)
@abdosi abdosi mentioned this pull request May 15, 2020
Merged
abdosi added a commit that referenced this pull request May 18, 2020
@abdosi
[Submodule update] sonic-utilities (#4601)
cb5221a 
Fix is_mgmt_vrf_enabled when MGMT_VRF_CONFIG is not present the config (#885)
Changes to support acl-loader command for multi-npu platforms. (#908)
Stop/Start restapi server upon config reload (#911)
[fanshow] Add column drawer name and led status to output of show
platform(#991)
[MultiDB] use sonic-db-cli instead of redis-cli in new added codes
(#907)
[show] Add `ntpstat` output to `show ntp` (#861)
[config] Log invocation of config commands to syslog (#259)
Remove dependency on click-default-group package (#903)
[config] Add 'interface transceiver' subgroup with 'lpmode' and 'rese…'
(#904)
[show] Add 'errors' and 'rates' subcommands to 'show interfaces
count…(#900)
[config] Support load_minigraph command for multi NPU platform (#896)
[Vnet] Fix NameError for 'swsssdk' and align output (#902)
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this pull request May 10, 2021
@yangshp1987
[show] Add ntpstat output to show ntp (sonic-net#861)
8bfa3b7 
Signed-off-by: yangshiping <[email protected]>
AidanCopeland pushed a commit to Metaswitch/sonic-buildimage that referenced this pull request Apr 14, 2022
@Pterosaur
Add function to refresh macsec sa stat (sonic-net#861)
539fdcd 
Signed-off-by: Ze Gan <[email protected]>
mssonicbld added a commit that referenced this pull request Apr 16, 2024
@mssonicbld
[submodule] Update submodule sonic-swss-common to the latest HEAD aut…
9c6724a 
…omatically (#18689)

#### Why I did it
src/sonic-swss-common
```
* 5a73792 - (HEAD -> master, origin/master, origin/HEAD) [subnet_decap] Introduce subnet decap tables (#861) (33 minutes ago) [Longxiang Lyu]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan approved these changes

@sihuihan88 sihuihan88 Awaiting requested review from sihuihan88

Assignees
No one assigned
Labels
Enhancement ➕ Submodule Update ⏫
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@taoyl-ms @lguohan @jleveque @msftclas