sonic yang changes for BUM storm control #7355
Conversation
| Rate is defined in bits-per-second. All three types of storm-control can be | ||
| enabled on an interface."; | ||
|
|
||
| revision 2019-09-03 { |
There was a problem hiding this comment.
Update the revision date.
| container PORT_STORM_CONTROL { | ||
| list PORT_STORM_CONTROL_LIST { | ||
| key "ifname storm_type"; | ||
| /*scommon:key-pattern "PORT_STORM_CONTROL|{ifname}:{storm_type}";*/ |
There was a problem hiding this comment.
Why do we have ":" in the key pattern, we should use "|"
| }, | ||
| "Ethernet0|unknown-unicast": { | ||
| "kbps": "20000" | ||
| } |
There was a problem hiding this comment.
Please write the actual UT cases as well e.g add cases in src/sonic-yang-models/tests/yang_model_tests/tests for this feature.
| enum unknown-multicast; | ||
| } | ||
| } | ||
| leaf kbps { |
There was a problem hiding this comment.
we can we use rate instead of kbps field name?
There was a problem hiding this comment.
rate might indicate the % of linerate. kbps would be a constant value irrespective of line-rate. Hence chose kbps.
There was a problem hiding this comment.
Sorry...I meant meaningful name than kbps e.g storm_limit..
There was a problem hiding this comment.
Okay. Do you recommend changing this in all the instances (CLI and orchagent) or only here.
There was a problem hiding this comment.
I recommend changing it in all places, but that can be done in a separate PR.
|
@mohan-selvaraj could you please join the YANG subgroup meeting and review with team? Thanks. |
|
@mohan-selvaraj please help to fix the conflict asap. |
Why I did it
Sonic yang model for BUM storm control
How I did it
Added yang model and the corresponding test cases.
How to verify it
yang model test case for storm control
Which release branch to backport (provide reason below if selected)
Description for the changelog
Addition of storm control yang model and corresponding tests to verify the same.
A picture of a cute animal (not mandatory but encouraged)