Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dockers]: Disable autorestart on all supervised processes inside containers #580

Merged
merged 1 commit into from
May 10, 2017
Merged

Conversation

jleveque
Copy link
Contributor

@jleveque jleveque commented May 9, 2017

By disabling autorestart on all processes and making them all one-shot runs, we regain our previous functionality.

In the near future, the plan will be to modify supervisord functionality as follows:

  • When a process managed by supervisord crashes, supervisord wil log the crash and exit immediately, thus causing the docker container to stop. The container will then be restarted by systemd as an atomic unit.

@jleveque jleveque self-assigned this May 9, 2017
@jleveque jleveque requested a review from lguohan May 9, 2017 18:37
@jleveque jleveque changed the title [dockers]: Disable autorestart on all supervisor processes inside containers [dockers]: Disable autorestart on all supervised processes inside containers May 9, 2017
@jleveque jleveque merged commit d5c13c0 into sonic-net:master May 10, 2017
@jleveque jleveque deleted the no_restart branch May 10, 2017 00:37
lguohan pushed a commit that referenced this pull request Jul 17, 2019
* ee56d54 2019-07-16 | [fast-reboot] Stop services after killing containers to prevent automatic restart (#572) (HEAD -> master, origin/master, origin/HEAD) [Joe LeVeque]
* c718cab 2019-07-17 | [acl_loader]: Fix show mirror_session error (#580) [JaredLius]
* 2764c6c 2019-07-16 | [Mellanox] Improve the prompt of the Mellanox sdk sniffer command. (#546) [Stephen Sun]
* 5a5b74d 2019-07-10 | Generate interface table to have an entry for default VRF (#525) [Prince Sunny]
* c30e9ff 2019-07-10 | [show] Don't abort in InterfaceAliasConverter ctor if PORT table doesn't exist (#571) [Joe LeVeque]
* 1aac696 2019-07-10 | [fast reboot] stop removing opennsl module before reboot (#560) [Ying Xie]
* 37823d4 2019-07-09 | Modified CLI doc for 201904 release, changed the config interface command, etc., (#561) [kannankvs]
* 77ae6b8 2019-07-03 | [PR template] Add reminder to update Command Line Reference Guide if modifying user-facing commands (#569) [Joe LeVeque]
* dc52015 2019-06-25 | [Sonic-utilities]: Added commands to view acl and port running configs (#557) [Prem Prakash]
* c7f45c3 2019-06-19 | [warm-reboot] Use retryCount option of orchagent_restart_check program (#555) [Jipan Yang]
* c6a08f7 2019-06-17 | [scripts]: add support to db_migrator for non-default unix socket (#551) [Lawrence Lee]
* 98e087f 2019-06-06 | [show]: Edit comment (#549) [Vasant Patil]
* 5667a90 2019-06-06 | [intfutil] Fix error when <interface name> specified in show interface related commands (#548) [Gord Chen]
* b7fcb1f 2019-06-04 | Add buffer pool watermark support in watermarkstat and counterpoll (#521) [Wenda Ni]
* 635dc88 2019-06-03 | [config]: Add config acl add/remove table command (#541) [Shuotian Cheng]
* dcdc922 2019-06-03 | [show]: Add show policer command (#540) [Shuotian Cheng]
* 82ef3ec 2019-06-01 | IP Address validation check (#530) [Tapash Das]
* 1f326ad 2019-05-31 | [show] Remove ability to clear counters from 'show' commands (#518) [Joe LeVeque]
* 669d36d 2019-06-01 | Add SONIC CLI Manual (#533) [kannankvs]
* 7657001 2019-06-01 | 'show vlan config' not displaying the VLAN members, after the clear config and reload with default l2 configuration. (#457) [RAMA CHANDRA REDDY GADDAM]
* 9493883 2019-05-28 | use vlan members (#542) [trzhang-msft]
* 128462a 2019-05-22 | [config]: Add --policer option for mirror session (#537) [Shuotian Cheng]
* 38da7f3 2019-05-22 | [acl_loader]: Add policer attribute in show mirror_session command (#538) [Shuotian Cheng]
* f95ff00 2019-05-22 | [acl_loader]: Do not apply default DENY rule for MIRRORV6 table (#522) [Shuotian Cheng]
* 50b7256 2019-05-21 | [sonic_installer] If asked to install an image which is already installed, simply set as default (#534) [Joe LeVeque]
* d823062 2019-05-20 | [201811] enable DB migrator code (#536) [Ying Xie]
* 7f7f384 2019-05-10 | update scheme variable name (#531) [trzhang-msft]
* c66315a 2019-05-10 | Config interface Loopback0 ip add/del is not working (#443) [Kiran Kumar Kella]
* 430d4b8 2019-05-10 | decode-syseeprom : added new option to show the Product Name. (#496) [Olivier Singla]
yxieca added a commit to yxieca/sonic-buildimage that referenced this pull request Sep 5, 2019
Submodule src/sonic-utilities 4f72e14..11b4cf1:
  > [fast-reboot] Check if ASIC config has changed before warm reboot (sonic-net#621)
  > [neighbor_advertiser]: Change the ICMPv6 type to 135 (sonic-net#629)
  > [acl_loader]: Fix show mirror_session error (sonic-net#580)

Signed-off-by: Ying Xie <[email protected]>
yxieca added a commit that referenced this pull request Sep 6, 2019
Submodule src/sonic-utilities 4f72e14..11b4cf1:
  > [fast-reboot] Check if ASIC config has changed before warm reboot (#621)
  > [neighbor_advertiser]: Change the ICMPv6 type to 135 (#629)
  > [acl_loader]: Fix show mirror_session error (#580)

Signed-off-by: Ying Xie <[email protected]>
Kalimuthu-Velappan pushed a commit to Kalimuthu-Velappan/sonic-buildimage that referenced this pull request Sep 12, 2019
madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this pull request Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants