Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HWSKU] [Marvell] Added HWSKU for Platform 98cx8580 #4205

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

antony-rheneus
Copy link
Contributor

Suuported profiles 32x400G and 16x400G

Signed-off-by: Antony Rheneus [email protected]

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Suuported profiles 32x400G and 16x400G

Signed-off-by: Antony Rheneus <[email protected]>
@jleveque
Copy link
Contributor

jleveque commented Mar 2, 2020

Retest vs please


@property
def get_transceiver_change_event(self):
raise NotImplementedError
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is get_transceiver_change_event() not implemented for any of the platforms in this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change Interrupt line was not provided in HW/CPLD.

@lguohan lguohan merged commit 4ed3fe4 into sonic-net:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants