You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the results you expected:
Should be able to build FRR without error after doing a clean-type operation (e.g. make clean, make target/debs/stretch/frr_7.0.1-sonic-0_amd64.deb-clean, rm -f target/debs/stretch/frr_7.0.1-sonic-0_amd64.deb, etc.).
Additional information you deem important (e.g. issue happens only occasionally):
This problem appears to have been introduced by PR-3017, where several patches are now being applied directly to the FRR source files. These patches apply cleanly the first time, when a fresh clone is used, but fail to apply in subsequent builds once the FRR source files have already been patched. This is causing the FRR rebuild process to fail.
Most other SONiC patched code relies on a source tree being downloaded fresh each time a given package is built/rebuilt, thus allowing the patches to be applied to unmodified source files. FRR stores its source files within the submodule repo, therefore the src/sonic-frr/Makefile cannot do an 'rm -rf' to start its build from a clean slate each time.
(Since the FRR source files are committed as part of the sonic-frr submodule repo, why is a patch process being used instead of just modifying the affected source files themselves within the branch?)
**Output of `show version`:**
```
(paste your output here)
```
**Attach debug file `sudo generate_dump`:**
```
(paste your output here)
```
The text was updated successfully, but these errors were encountered:
Description
The SONiC FRR code can only be built from a fresh clone, but causes a build error when rebuilding after a clean operation.
Steps to reproduce the issue:
Describe the results you received:
Describe the results you expected:
Should be able to build FRR without error after doing a clean-type operation (e.g. make clean, make target/debs/stretch/frr_7.0.1-sonic-0_amd64.deb-clean, rm -f target/debs/stretch/frr_7.0.1-sonic-0_amd64.deb, etc.).
Additional information you deem important (e.g. issue happens only occasionally):
This problem appears to have been introduced by PR-3017, where several patches are now being applied directly to the FRR source files. These patches apply cleanly the first time, when a fresh clone is used, but fail to apply in subsequent builds once the FRR source files have already been patched. This is causing the FRR rebuild process to fail.
Most other SONiC patched code relies on a source tree being downloaded fresh each time a given package is built/rebuilt, thus allowing the patches to be applied to unmodified source files. FRR stores its source files within the submodule repo, therefore the src/sonic-frr/Makefile cannot do an 'rm -rf' to start its build from a clean slate each time.
(Since the FRR source files are committed as part of the sonic-frr submodule repo, why is a patch process being used instead of just modifying the affected source files themselves within the branch?)
The text was updated successfully, but these errors were encountered: