-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable to audit at the end #25
Comments
3.0.3 (and now 3.0.4) have a persistent cache that helps avoid 429 issues. But I also recommend, that you only audit the final output of your project. If your project is a collection of modules intended to be used, then I think per-module is still sane to allow your build to fail on specific modules so you can more easily fix those problems. We may consider an audit-at-end, but atm we believe that the persistent cache should help alleviate most of these problems. Also with audit-at-end you could still see rate limiting if you can concurrency for builds, so we think the cache is probably the better solution vs. adding complication to your built to register audit-at-end functionality. If you can give the latest release a try and report back it would be helpful. Thanks for your report! |
Agree it is less useful with this caching (I was not using) but it still works in concurrency builds (the counter is an atomicinteger, this is what do deploy plugin) and it enables a reporting for all modules (sadly I have like 15 deliverables in that project between testing libs, webapps and runtime libs) instead of running, fixing module1, running, fixing module 5 etc...so can still be worth IMHO |
@rmannibucau will leave this as an enhancement request for now; though I do not know when we'll have time to add this feature ATM. But I agree its potentially useful optional feature. |
Works for me, and thanks for the upgrade tip, it already helped! |
Goal is to go through all the modules, store in the maven session the dependencies, and when the last module is hit call the server to audit all the dependencies at once, then just report the found issues.
This should solve the HTTP 429 issue for large project and make the analyzis even faster.
The text was updated successfully, but these errors were encountered: