Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements TransactionalManagerInterface #442

Closed
eerison opened this issue Aug 11, 2022 · 6 comments
Closed

Implements TransactionalManagerInterface #442

eerison opened this issue Aug 11, 2022 · 6 comments
Labels

Comments

@eerison
Copy link
Contributor

eerison commented Aug 11, 2022

Implements TransactionalManagerInterface and Use in SnapshotManagerInterface

This idea was raised in this PR: sonata-project/SonataPageBundle#1548

  • Create test for Create and cleanup snapshots, to make sure that beginTransaction and commit methods are called
@eerison
Copy link
Contributor Author

eerison commented Aug 11, 2022

Ok we have the first problem here, sonata-doctrine-extension requires php 8

https://github.com/sonata-project/sonata-doctrine-extensions/blob/2.x/composer.json

But in my option we should release 4.0 with support for 7.4 what do you think?

@eerison
Copy link
Contributor Author

eerison commented Aug 11, 2022

@VincentLanglet

@VincentLanglet
Copy link
Member

VincentLanglet commented Aug 11, 2022

Ok we have the first problem here, sonata-doctrine-extension requires php 8

https://github.com/sonata-project/sonata-doctrine-extensions/blob/2.x/composer.json

But in my option we should release 4.0 with support for 7.4 what do you think?

It's not a problem. We can still introduce the feature for now.
And we'll use it on PageBundle when the support for php 7.4/doctrine-extensions 2 will be dropped.

@eerison
Copy link
Contributor Author

eerison commented Aug 11, 2022

Ok we have the first problem here, sonata-doctrine-extension requires php 8
https://github.com/sonata-project/sonata-doctrine-extensions/blob/2.x/composer.json
But in my option we should release 4.0 with support for 7.4 what do you think?

It's not a problem. We can still introduce the feature for now. And we'll use it on PageBundle when the support for php 7.4/doctrine-extensions 2 will be dropped.

Ok I got it ;)

@jordisala1991
Copy link
Member

IMO this issue should be moved to doctrine extensions

@jordisala1991 jordisala1991 transferred this issue from sonata-project/SonataPageBundle Aug 11, 2022
@jordisala1991 jordisala1991 changed the title Implements TransactionalManagerInterface and Use in SnapshotManagerInterface Implements TransactionalManagerInterface Aug 11, 2022
@eerison
Copy link
Contributor Author

eerison commented Aug 16, 2022

I would say it's done

@eerison eerison closed this as completed Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants