-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide autowiring for Exporter class #244
Comments
IMO its not a best practice to do that for a third party bundle, but I can be wrong No need to do it in PHP, you can define an alias in your services.yaml file |
See symfony/symfony-docs#9886 not sure if we should do that for no services at all, or allow doing it for services relevant to the end user |
Where did you see that? It's done on many bundles. And how will you provide auto-wiring without this method? The only better thing to do here is to provide an interface. |
@OskarStark please see https://github.com/symfony/symfony-docs/blob/master/bundles/best_practices.rst#services, apparently the best practice is exactly what is proposed here. |
@Jerome1337 would you please make a pull request for this? |
Feature Request
Provide autowiring for
sonata.exporter.exporter
classI actually need to use this workaround inside
Kernel.php
The text was updated successfully, but these errors were encountered: