Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to BlockBundle v4 #785

Closed
8 of 15 tasks
wbloszyk opened this issue Jul 21, 2020 · 3 comments
Closed
8 of 15 tasks

Add support to BlockBundle v4 #785

wbloszyk opened this issue Jul 21, 2020 · 3 comments

Comments

@wbloszyk
Copy link
Member

wbloszyk commented Jul 21, 2020

TODO:

  • sandbox
    • AccountBlockService extends AbstractAdminBlockService
    • NewsletterBlockService extends BaseBlockService
  • ecommerce
    • Basket
      • BasketBlockService extends AbstractAdminBlockService
    • Customer
      • final class ProfileMenuBlockService extends MenuBlockService
      • RecentCustomersBlockService extends AbstractAdminBlockService
    • Order
      • RecentOrdersBlockService extends BaseBlockService
    • Product
      • CatalogBreadcrumbBlockService extends BaseBreadcrumbMenuBlockService
      • CategoriesMenuBlockService extends MenuBlockService
      • FiltersMenuBlockService extends MenuBlockService
      • RecentProductsBlockService extends BaseBlockService
      • SimilarProductsBlockService extends BaseBlockService
      • VariationsFormBlockService extends BaseBlockService
  • SonataAdminBundle
    • AdminListBlockService extends AbstractBlockService
    • AdminSearchBlockService extends AbstractBlockService
    • AdminStatsBlockService extends AbstractBlockService
  • SonataClassificationBundle
    • AbstractCategoriesBlockService extends AbstractClassificationBlockService
    • AbstractClassificationBlockService extends AbstractAdminBlockService
    • AbstractCollectionsBlockService extends AbstractClassificationBlockService
    • AbstractTagsBlockService extends AbstractClassificationBlockService
  • SonataCommentBundle
    • CommentThreadAsyncBlockService extends BaseBlockService
  • SonataDashboardBundle
    • ContainerBlockService extends BaseContainerBlockService
  • SonataDoctrineORMAdminBundle
    • AuditBlockService extends AbstractBlockService
  • SonataDoctrinePhpcrAdminBundle
    • TreeBlockService extends AbstractBlockService
  • SonataFormatterBundle
    • FormatterBlockService extends AbstractAdminBlockService
  • SonataMediaBundle
    • Breadrumb
      • BaseGalleryBreadcrumbBlockService extends BaseBreadcrumbMenuBlockService
      • GalleryIndexBreadcrumbBlockService extends BaseGalleryBreadcrumbBlockService
      • GalleryViewBreadcrumbBlockService extends BaseGalleryBreadcrumbBlockService
      • MediaViewBreadcrumbBlockService extends BaseGalleryBreadcrumbBlockService
    • FeatureMediaBlockService extends MediaBlockService
    • GalleryBlockService extends AbstractBlockService
    • GalleryListBlockService extends AbstractBlockService
    • MediaBlockService extends AbstractBlockService
  • SonataNewsBundle
    • Breadcrumb
      • BaseNewsBreadcrumbBlockService extends BaseBreadcrumbMenuBlockService
      • NewsArchiveBreadcrumbBlockService extends BaseNewsBreadcrumbBlockService
      • NewsPostBreadcrumbBlockService extends BaseNewsBreadcrumbBlockService
    • RecentCommentsBlockService extends AbstractAdminBlockService
    • RecentPostsBlockService extends AbstractAdminBlockService
  • SonataPageBundle
    • BlockContextManager extends BaseBlockContextManager
    • BreadcrumbBlockService extends BaseBreadcrumbMenuBlockService
    • ChildrenPagesBlockService extends AbstractAdminBlockService
    • ContainerBlockService extends BaseContainerBlockService
    • PageListBlockService extends AbstractAdminBlockService
    • SharedBlockBlockService extends AbstractAdminBlockService
  • SonataSeoBundle
    • Breadcrumb
      • BaseBreadcrumbMenuBlockService extends MenuBlockService
      • HomepageBreadcrumbBlockService extends BaseBreadcrumbMenuBlockService
    • Social
      • BaseFacebookSocialPluginsBlockService extends AbstractAdminBlockService
      • BaseTwitterButtonBlockService extends AbstractAdminBlockService
      • EmailShareButtonBlockService extends AbstractAdminBlockService
      • FacebookLikeBoxBlockService extends BaseFacebookSocialPluginsBlockService
      • FacebookLikeButtonBlockService extends BaseFacebookSocialPluginsBlockService
      • FacebookSendButtonBlockService extends BaseFacebookSocialPluginsBlockService
      • FacebookShareButtonBlockService extends BaseFacebookSocialPluginsBlockService
      • PinterestPinButtonBlockService extends AbstractAdminBlockService
      • TwitterEmbedTweetBlockService extends BaseTwitterButtonBlockService
      • TwitterFollowButtonBlockService extends BaseTwitterButtonBlockService
      • TwitterHashtagButtonBlockService extends BaseTwitterButtonBlockService
      • TwitterMentionButtonBlockService extends BaseTwitterButtonBlockService
      • TwitterShareButtonBlockService extends BaseTwitterButtonBlockService
  • SonataTimelineBundle
    • TimelineBlock extends AbstractAdminBlockService
  • SonataTranslationBundle
    • LocaleSwitcherBlockService extends AbstractBlockService
@wbloszyk
Copy link
Member Author

IMHO, Support for BlockBundle v4 should not be add in Sonata 3, It can be done in easy way when block will be final. Also in Sonata 4 support for BlockBundle v3 can be keep.

We should consider add support for BlockBuindle v4 (useful for standalone Admin):

  • SonataAdminBundle
  • SonataDoctrineORMAdminBundle
  • SonataDoctrinePhpcrAdminBundle
  • SonataTranslationBundle

WDYT? Can you ping contributors too? @jordisala1991

@jordisala1991
Copy link
Member

There are some bundles that could be hard to upgrade, but some others are easy and should be upgraded

@VincentLanglet
Copy link
Member

VincentLanglet commented Nov 28, 2021

Now we deprecated multiple bundles, the only non-deprecated bundle without the support of BlockBundle v4 is the page bundle.

Since we're using deprecated classes in SonataPage v3, adding the v4 support doesn't seems possible to me.
So I'll closing this in favor of #1715

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants