Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Twig directly in sonata-project bundles without proxy classes, Stage 2 #390

Closed
1 of 15 tasks
covex-nn opened this issue Feb 5, 2018 · 1 comment
Closed
1 of 15 tasks

Comments

@covex-nn
Copy link

covex-nn commented Feb 5, 2018

Stage 2 goes after Stage 1, all changes must be pushed to master branch of each repository, because this is BC breaks.

There are 15 bundles, where were changes during Stage 1 and where Sonata\BlockBundle\Templating\TwigEngine is used now instead of Symfony\Bundle\TwigBundle\TwigEngine:

  • BlockBundle
  • AdminBundle
  • SeoBundle
  • PageBundle
  • DoctrineORMAdminBundle
  • DoctrinePhpcrAdminBundle
  • FormatterBundle
  • MediaBundle
  • UserBundle
  • NewsBundle
  • ArticleBundle
  • TranslationBundle
  • TimelineBundle
  • CommentBundle
  • DashboardBundle

BlockBundle must be updated in accordance with the plan or close to it.

For other bundles we should search for EngineInterface in src directory, change type hint to Twig\Environment and update tests. Also we should search for templating service in docs directory and change it to twig.

@covex-nn
Copy link
Author

covex-nn commented Feb 6, 2018

Update (remove?) sonata-project/block-bundle version inside "conflict" section of composer.json

  • UserBundle
  • SeoBundle
  • MediaBundle
  • CommentBundle
  • ArticleBundle
  • NewsBundle
  • DoctrineORMAdminBundle

See #380 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants