From 8129d46292ba3b51db873b83ef25aeff1853eba6 Mon Sep 17 00:00:00 2001 From: Erison Silva Date: Tue, 6 Sep 2022 15:16:51 +0200 Subject: [PATCH 1/2] Deprecated assets option --- src/DependencyInjection/Configuration.php | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/DependencyInjection/Configuration.php b/src/DependencyInjection/Configuration.php index db45d3232..64cfe7d3c 100644 --- a/src/DependencyInjection/Configuration.php +++ b/src/DependencyInjection/Configuration.php @@ -181,6 +181,12 @@ public function getConfigTreeBuilder() ->end() ->arrayNode('assets') + ->setDeprecated( + ...$this->getDeprecationMessage( + 'The "assets" option is deprecated since sonata-project/page-bundle 3.28.0 and will be removed in 4.0', + '3.28' + ) + ) ->addDefaultsIfNotSet() ->children() ->arrayNode('stylesheets') From 476a781582b6a3b47def6a17e0cf855bb2fc4b5d Mon Sep 17 00:00:00 2001 From: Erison Silva Date: Wed, 7 Sep 2022 08:51:04 +0200 Subject: [PATCH 2/2] Added upgrade note --- UPGRADE-3.x.md | 7 +++++++ src/DependencyInjection/Configuration.php | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/UPGRADE-3.x.md b/UPGRADE-3.x.md index 909dbeb5c..ff20e8194 100644 --- a/UPGRADE-3.x.md +++ b/UPGRADE-3.x.md @@ -1,6 +1,13 @@ UPGRADE 3.x =========== +UPGRADE FROM 3.28 to 3.29 +========================= + +### Deprecate assets config + +The `sonata_page.assets` option was deprecated, and it will be removed on 4.x + UPGRADE FROM 3.25 to 3.26 ========================= diff --git a/src/DependencyInjection/Configuration.php b/src/DependencyInjection/Configuration.php index 64cfe7d3c..df35a4ebb 100644 --- a/src/DependencyInjection/Configuration.php +++ b/src/DependencyInjection/Configuration.php @@ -184,7 +184,7 @@ public function getConfigTreeBuilder() ->setDeprecated( ...$this->getDeprecationMessage( 'The "assets" option is deprecated since sonata-project/page-bundle 3.28.0 and will be removed in 4.0', - '3.28' + '3.29' ) ) ->addDefaultsIfNotSet()