-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incompatible requirements with symfony 4 #771
Comments
I think making it optional could be a good first step |
Can it be removed in next release from requirements then? Because I think now it is impossible to use SonataAdmin with doctrine and symfony 4 because of this. |
Yes, it can. Please make a PR. |
@greg0ire I do not know if it is safe to simply remove that requirement. Do you? Shouldn't somebody who knows what he is doing, do this change? Actually, in my opinion, perhaps the best is to simply remove it because it is incompatible and |
First, please prove that it has indeed incompatible requirements. I gave it a quick look and it doesn't seem so. |
@greg0ire The problem is because latest release of But more over,
|
I'm all for it, but we can't do this in a minor. So maybe we'll do it in the next major, to be discussed, but before that, moving that requirement would be good IMO. |
It should be a require-dev on 3.x (that one will be easy) and it could be removed on master (this will take a lot of work) |
|
Link for the lazy: https://packagist.org/packages/symfony/security-acl#v3.0.1 |
Thanks @jaikdean ! |
sonata-project/doctrine-orm-admin-bundle
requiresymfony/security-acl ^2.8 || ^3.0
which has incompatible requirements. Besidessymfony/security-acl
seems to be abandoned?Will there be a resolution for this?
The text was updated successfully, but these errors were encountered: