New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split SonataAdminExtension twig extension in smaller extensions #6639

Closed

franmomu opened this issue Nov 30, 2020 · 0 comments · Fixed by #6676

Labels

Easy Pick feature

Member

franmomu commented Nov 30, 2020 •

edited

Loading

Feature Request

SonataAdminExtension does too many different things, it could be split in some independent twig extensions:

CanonicalizerExtension (or other name) with twig functions canonicalize_locale_for_moment and canonicalize_locale_for_select2.
SecurityExtension with twig function is_granted_affirmative so SonataAdminExtension wouldn't need AuthorizationCheckerInterface anymore.
XEditableExtension with twig filters sonata_xeditable_type and sonata_xeditable_choices with TranslatorInterface.

And it would also make SonataAdminExtensionTest smaller.

The text was updated successfully, but these errors were encountered:

franmomu added Easy Pick feature labels

tambait mentioned this issue

[Twig] Split SonataAdminExtension #6676

Merged

VincentLanglet closed this as completed in #6676

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment