You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
FieldDescriptionInterface should not expose getParentAssociationMappings and getAssociationMappings methods or there should stop returning an array
#6274
Closed
VincentLanglet opened this issue
Aug 11, 2020
· 4 comments
Currently FieldDescriptionInterface::parentAssociationMappings() and associationMappings() methods are returning array.
Thanks to #6219 (comment), I discovered that the array keys are not the same for our different storage bundle. This means that these array should not be used in SonataAdminBundle.
I found two solutions
Exposing some methods like getParentAssociationFieldName(), getAssociationFieldName(), ... instead.
Exposing a new AssociationMapping interface, which will be implemented by storage bundle. And getParentAssociationMappings/getAssociationMappings should return this interface instead.
The second solution seems better, but this can't be done in a BC-way isn't it ? @sonata-project/contributors
The text was updated successfully, but these errors were encountered:
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Feature Request
Currently FieldDescriptionInterface::parentAssociationMappings() and associationMappings() methods are returning array.
Thanks to #6219 (comment), I discovered that the array keys are not the same for our different storage bundle. This means that these array should not be used in SonataAdminBundle.
I found two solutions
The second solution seems better, but this can't be done in a BC-way isn't it ? @sonata-project/contributors
The text was updated successfully, but these errors were encountered: