Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove $context from AdminInterface::createQuery #3795

Closed
soullivaneuh opened this issue May 11, 2016 · 1 comment
Closed

Remove $context from AdminInterface::createQuery #3795

soullivaneuh opened this issue May 11, 2016 · 1 comment
Assignees
@soullivaneuh

Comments

@soullivaneuh
Copy link
Member

This variable could not be modified anywhere as specified on #3246.

But @greg0ire detected an OCP violation on my PR. See #3247 (comment)

So as he suggested, this parameter should be simply removed.

TODO: See if this could be done on a BC way.
@soullivaneuh soullivaneuh self-assigned this May 11, 2016
This was referenced May 11, 2016
Closed
Closed
Closed
@greg0ire
Copy link
Contributor

greg0ire commented Jun 8, 2016 •
edited
Loading

TODO: See if this could be done on a BC way.

func_num_args() can be used to tell if you are using the default argument or not. Making a PR right now.

@greg0ire greg0ire mentioned this issue Jun 8, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soullivaneuh soullivaneuh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@greg0ire @soullivaneuh