From fad2b3fa2699e18413fba7beda0999ae8b15091e Mon Sep 17 00:00:00 2001 From: Sonata CI Date: Mon, 20 Nov 2023 08:55:58 +0000 Subject: [PATCH] DevKit updates for 4.x branch (#8123) Co-authored-by: Vincent Langlet --- .github/workflows/test.yaml | 4 ---- .../Compiler/AddDependencyCallsCompilerPass.php | 4 ++-- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 6309941021..f9a7e616d4 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -42,10 +42,6 @@ jobs: dependencies: lowest allowed-to-fail: false variant: normal - - php-version: '8.2' - dependencies: highest - allowed-to-fail: false - variant: sonata-project/block-bundle:"5.0.0-alpha-1" - php-version: '8.2' dependencies: highest allowed-to-fail: false diff --git a/src/DependencyInjection/Compiler/AddDependencyCallsCompilerPass.php b/src/DependencyInjection/Compiler/AddDependencyCallsCompilerPass.php index 5cd25857eb..70f24cc3bd 100644 --- a/src/DependencyInjection/Compiler/AddDependencyCallsCompilerPass.php +++ b/src/DependencyInjection/Compiler/AddDependencyCallsCompilerPass.php @@ -396,8 +396,8 @@ private function getDefaultMethodCalls(ContainerBuilder $container, string $serv \E_USER_DEPRECATED ); - // NEXT_MAJOR: Uncomment the exception instead of the deprecation. - // throw new InvalidArgumentException(sprintf('Missing tag information "model_class" on service "%s".', $serviceId)); + // NEXT_MAJOR: Uncomment the exception instead of the deprecation. + // throw new InvalidArgumentException(sprintf('Missing tag information "model_class" on service "%s".', $serviceId)); } else { $methodCalls[] = ['setModelClass', [$modelClass]];