From 89fb8b22e5729aabd24ae840fefcbcfb7c7a459c Mon Sep 17 00:00:00 2001 From: Vincent Langlet Date: Thu, 8 Apr 2021 21:39:22 +0200 Subject: [PATCH] Review --- src/DependencyInjection/Configuration.php | 2 +- src/Exception/AuditException.php | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/DependencyInjection/Configuration.php b/src/DependencyInjection/Configuration.php index 6ab4af41..c9c3559e 100644 --- a/src/DependencyInjection/Configuration.php +++ b/src/DependencyInjection/Configuration.php @@ -46,7 +46,7 @@ public function getConfigTreeBuilder() ->scalarNode('revision_table_name')->defaultValue('revisions')->end() ->scalarNode('revision_id_field_type') ->defaultValue('integer') - // NEXT_MAJOR: Use validate() instead. + // NEXT_MAJOR: Use enumNode() instead. ->beforeNormalization() ->always(static function ($value) { if (null !== $value && !\in_array($value, self::ALLOWED_REVISION_ID_FIELD_TYPE, true)) { diff --git a/src/Exception/AuditException.php b/src/Exception/AuditException.php index 7c68aaa8..ecfab0e3 100644 --- a/src/Exception/AuditException.php +++ b/src/Exception/AuditException.php @@ -30,6 +30,9 @@ abstract class AuditException extends \Exception */ protected $revision; + /** + * @param int|string|null $revision + */ public function __construct(?string $className, ?array $id, $revision) { $this->className = $className;