Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check environment effectiveness after enabling #78

Open
mlouielu opened this issue Aug 9, 2021 · 6 comments
Open

Check environment effectiveness after enabling #78

mlouielu opened this issue Aug 9, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@mlouielu
Copy link

mlouielu commented Aug 9, 2021

I assume after enable environment, we can achieve some isolate build environment,
but in README usage we cannot know the effectiveness of this environment.

(e.g. poetry run python --version can check Python version difference between system python & poetry shell python).

We should add a PoC after enable environment make new user know what happen.

@yungyuc
Copy link
Member

yungyuc commented Aug 9, 2021

I assume after enable environment, we can achieve some isolate build environment,
but in README usage we cannot know the effectiveness of this environment.

(e.g. poetry run python --version can check Python version difference between system python & poetry shell python).

We should add a PoC after enable environment make new user know what happen.

Indeed we do not have a helper to check for the validity. We should improve it.

But what does PoC stand for?

@yungyuc yungyuc added the enhancement New feature or request label Aug 9, 2021
@mlouielu
Copy link
Author

mlouielu commented Aug 9, 2021

Proof of Concept (PoC), maybe like pkg-config --cflags <some_wide_spread_library> and return -1 in devenv environment?

@yungyuc
Copy link
Member

yungyuc commented Aug 9, 2021

Correct me if I am wrong. You are talking about adding a description in README to explan how a new environment is in effect after enabling it (devenv use xxx).

I was talking about an additional function / command / helper in devenv that does the check, and the README can use it to describe the effect.

I think both approaches are OK.

@mlouielu
Copy link
Author

mlouielu commented Aug 9, 2021

Both are OK, borrow from poetry, poetry debug will show current environment information like:

$ poetry debug

Poetry
Version: 1.1.7
Python:  3.9.6

Virtualenv
Python:         3.9.6
Implementation: CPython
Path:           /home/louie/xxx/.venv
Valid:          True

System
Platform: linux
OS:       posix
Python:   /usr

maybe devenv can print out information like above.

@tai271828
Copy link
Collaborator

+1 to the additional function in devenv that does basic check like poetry debug. Besides, my gut feeling shows that kind of debugging function could be helpful and applied to initial tests like https://github.com/solvcon/devenv/blob/main/tests/test_init_var.sh .

@yungyuc yungyuc changed the title README usage missing PoC after enable environment Check environment effectiveness after enabling Aug 9, 2021
@yungyuc
Copy link
Member

yungyuc commented Aug 9, 2021

Renamed the issue. Let's see when we can work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants