Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UEFI - Allow user to select ESP for bootloader installation. #36

Open
deepakkapoor23 opened this issue May 15, 2017 · 3 comments
Open

Comments

@deepakkapoor23
Copy link

Installer detects all ESPs but only shows the first suitable one as an option in combobox.

def get_suitable_esp(self):
""" Attempt to find the suitable ESP.... """
l = self.dp.collect_esp()
if not l:
return None
e = l[0]
if e.freespace < ESP_FREE_REQUIRED:
return None
return e

@ikeydoherty
Copy link
Member

And the issue with that is... ?

@deepakkapoor23
Copy link
Author

Installer is not listing all available ESPs on the system. It only shows the first one it finds with more than 60Mb free space.

List all of them during installation with free space available and let the user decide. Also show a note on screen that at least 60Mb is required.

@ikeydoherty
Copy link
Member

You do realise that many systems will happily ignore multiple ESPs - and it's typically only full desktops that are OK with it? Laptops of various vendors (read: shitty firmware) can struggle with multiple ESPs, or just completely ignore them, or provide no mechanism at all to select a secondary.

Sidenote, the method returns the largest ESP with more than 60MB free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants