From 0d0f24021a6c0d44ca5e2d2b9c3ae4bb8d6c00c8 Mon Sep 17 00:00:00 2001 From: Matt Hamilton Date: Wed, 20 May 2020 23:46:40 -0400 Subject: [PATCH] add DCO, add note about ig-test pf delay --- docs/kubetap_development/TODOs.md | 7 ------- scripts/ig-test.zsh | 8 ++++++-- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/docs/kubetap_development/TODOs.md b/docs/kubetap_development/TODOs.md index 7b7de3e..eeb65d9 100644 --- a/docs/kubetap_development/TODOs.md +++ b/docs/kubetap_development/TODOs.md @@ -52,10 +52,3 @@ Don't want to force alpha features on anyone, but once this is in beta this will probably be the way forward. Will revisit. https://kubernetes.io/docs/concepts/workloads/pods/ephemeral-containers/ - -## Management - -### Add DCO - -https://probot.github.io/apps/dco/ - diff --git a/scripts/ig-test.zsh b/scripts/ig-test.zsh index 84b0798..c351f74 100755 --- a/scripts/ig-test.zsh +++ b/scripts/ig-test.zsh @@ -76,7 +76,9 @@ if (( readyCt != 1 )); then fi unset readyCt -sleep 10 +# without a delay here, port forwards occasionally fail. Need +# to implement kubectl ready check like in kubetap. +sleep 15 kubectl port-forward svc/grafana -n default 2244:2244 & _kubetap_pf_one_pid=${!} kubectl port-forward svc/grafana -n default 4000:80 & @@ -117,7 +119,9 @@ if (( readyCt != 1 )); then fi unset readyCt -sleep 10 +# without a delay here, port forwards occasionally fail. Need +# to implement kubectl ready check like in kubetap. +sleep 15 kubectl port-forward svc/dw-dokuwiki -n default 2244:2244 & _kubetap_pf_one_pid=${!} kubectl port-forward svc/dw-dokuwiki -n default 4000:80 &