From 153f6f5991a0ccf0f17746f6283e1812706fe01d Mon Sep 17 00:00:00 2001 From: Zhigao Tong Date: Wed, 1 Feb 2023 23:50:10 +0800 Subject: [PATCH] revert `squashing_transform` in HashJoinProbeBlockInputStream ---- merge output blocks if need in hash join #6529 816b8d5d5dff61b7fa452311c0b666947c34deb8 ---- --- .../DataStreams/HashJoinProbeBlockInputStream.cpp | 14 +------------- .../DataStreams/HashJoinProbeBlockInputStream.h | 1 - 2 files changed, 1 insertion(+), 14 deletions(-) diff --git a/dbms/src/DataStreams/HashJoinProbeBlockInputStream.cpp b/dbms/src/DataStreams/HashJoinProbeBlockInputStream.cpp index 283883fee13..2d40d1295c5 100644 --- a/dbms/src/DataStreams/HashJoinProbeBlockInputStream.cpp +++ b/dbms/src/DataStreams/HashJoinProbeBlockInputStream.cpp @@ -26,7 +26,6 @@ HashJoinProbeBlockInputStream::HashJoinProbeBlockInputStream( , join(join_) , probe_index(probe_index_) , probe_process_info(max_block_size) - , squashing_transform(max_block_size) { children.push_back(input); @@ -85,18 +84,7 @@ Block HashJoinProbeBlockInputStream::readImpl() { try { - // if join finished, return {} directly. - if (squashing_transform.isJoinFinished()) - { - return Block{}; - } - - while (squashing_transform.needAppendBlock()) - { - Block result_block = getOutputBlock(); - squashing_transform.appendBlock(result_block); - } - auto ret = squashing_transform.getFinalOutputBlock(); + Block ret = getOutputBlock(); return ret; } catch (...) diff --git a/dbms/src/DataStreams/HashJoinProbeBlockInputStream.h b/dbms/src/DataStreams/HashJoinProbeBlockInputStream.h index 23c64dfd8ba..fb4213cff54 100644 --- a/dbms/src/DataStreams/HashJoinProbeBlockInputStream.h +++ b/dbms/src/DataStreams/HashJoinProbeBlockInputStream.h @@ -66,7 +66,6 @@ class HashJoinProbeBlockInputStream : public IProfilingBlockInputStream size_t probe_index; ProbeProcessInfo probe_process_info; BlockInputStreamPtr non_joined_stream; - SquashingHashJoinBlockTransform squashing_transform; ProbeStatus status{ProbeStatus::PROBE}; size_t joined_rows = 0; size_t non_joined_rows = 0;