Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AssemblyScript filters created for Istio 1.7 are not showing as compatible #216

Closed
Sodman opened this issue Oct 29, 2020 · 1 comment · Fixed by #217 or #218
Closed

AssemblyScript filters created for Istio 1.7 are not showing as compatible #216

Sodman opened this issue Oct 29, 2020 · 1 comment · Fixed by #217 or #218
Assignees
@Sodman
Labels
bug Something isn't working

Comments

@Sodman
Copy link
Member

Sodman commented Oct 29, 2020

Describe the bug
In wasme v0.0.29, create an assemblyscript filter targeting Istio 1.7.

The filter itself will work with Istio 1.7, but the example generated by wasme init is missing the version information from the runtime-config.json to allow it to deploy to Istio 1.7.

Expected behavior
This deployment should work without having to specify --ignore-verison-check flag.

Additional context
This bug is specific to Istio 1.7 and wasme v0.0.29
@Sodman Sodman added the bug Something isn't working label Oct 29, 2020
@Sodman Sodman self-assigned this Oct 29, 2020
@Sodman Sodman mentioned this issue Oct 29, 2020
Merged
@Sodman Sodman mentioned this issue Oct 30, 2020
Merged
@Sodman
Copy link
Member Author

Sodman commented Oct 30, 2020

Not quite fixed yet, we missed codegen to pull the latest AS bundle into the wasme binary.

@Sodman Sodman reopened this Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sodman Sodman

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Istio 1.7 / Assemblyscript solo-io/wasm
Update assemblyscript bundle solo-io/wasm
1 participant
@Sodman