Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrading k8s client-go to 1.14.3 to fix deployment for aws eks #227

Closed
wants to merge 4 commits into from
Closed

upgrading k8s client-go to 1.14.3 to fix deployment for aws eks #227

wants to merge 4 commits into from

Conversation

ageekymonk
Copy link

This fixes #226

@solo-git-bot
Copy link

solo-git-bot bot commented Jul 9, 2019

Waiting for approval from someone in the solo-io org to start testing.

@mitchdraft
Copy link
Contributor

/test

@mitchdraft
Copy link
Contributor

@ageekymonk thanks for putting this together. Looks like the skaffold api changed with the version bump:

Step #8 - e2e-test": # github.com/solo-io/squash/vendor/github.com/GoogleContainerTools/skaffold/pkg/skaffold/kubernetes
Step #8 - "e2e-test": vendor/github.com/GoogleContainerTools/skaffold/pkg/skaffold/kubernetes/log.go:72:3: unknown field 'IncludeUninitialized' in struct literal of type "github.com/solo-io/squash/vendor/k8s.io/apimachinery/pkg/apis/meta/v1".ListOptions
Step #8 - "e2e-test": vendor/github.com/GoogleContainerTools/skaffold/pkg/skaffold/kubernetes/wait.go:44:4: unknown field 'IncludeUninitialized' in struct literal of type "github.com/solo-io/squash/vendor/k8s.io/apimachinery/pkg/apis/meta/v1".GetOptions
Step #8 - "e2e-test": vendor/github.com/GoogleContainerTools/skaffold/pkg/skaffold/kubernetes/wait.go:59:4: unknown field 'IncludeUninitialized' in struct literal of type "github.com/solo-io/squash/vendor/k8s.io/apimachinery/pkg/apis/meta/v1".GetOptions
Step #8 - "e2e-test": vendor/github.com/GoogleContainerTools/skaffold/pkg/skaffold/kubernetes/wait.go:80:4: unknown field 'IncludeUninitialized' in struct literal of type "github.com/solo-io/squash/vendor/k8s.io/apimachinery/pkg/apis/meta/v1".GetOptions
Step #8 - "e2e-test": vendor/github.com/GoogleContainerTools/skaffold/pkg/skaffold/kubernetes/wait.go:193:11: undefined: watch.Until
Step #8 - "e2e-test": vendor/github.com/GoogleContainerTools/skaffold/pkg/skaffold/kubernetes/wait.go:223:11: undefined: watch.Until
Step #8 - "e2e-test": 
Step #8 - "e2e-test":

Let me know when you'd like to run the ci again

Even if you don't have your env set up to run the e2e you should be able to reproduce this by triggering the e2e: ginkgo -r -failFast

@mitchdraft
Copy link
Contributor

/kick

@mitchdraft
Copy link
Contributor

/test

@mitchdraft
Copy link
Contributor

@ageekymonk could you change the target cluster to "squash-test" in https://github.com/solo-io/squash/blob/master/cloudbuild.yaml#L87
I think the test-cluster might be out of date

@mitchdraft
Copy link
Contributor

/test

@techniumlabs techniumlabs closed this by deleting the head repository May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update client-go, EKS compatibility
3 participants
@ageekymonk @mitchdraft @techniumlabs