Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ResourceFuncs usage was removed from rendering manifests #519

Open
inFocus7 opened this issue Nov 28, 2023 · 1 comment
Open

ResourceFuncs usage was removed from rendering manifests #519

inFocus7 opened this issue Nov 28, 2023 · 1 comment

Comments

@inFocus7
Copy link
Contributor

Context

A previous update to support conditional CRD rendering removed our usage of ResourceFuncs. Previously while rendering we went through the ResourceFuncs functions to add to our manifest rendered, but now we don't have any logic doing so.

https://github.com/solo-io/skv2/pull/462/files#diff-813e5efb857f3e8d15508b847892b877943384a6e05532b633e99a5765d66a17L74-L81

Additional Notes

  • I'm unsure if this was intentional, but I didn't see any notes regarding it.
    • If it was intentional, should we just remove ResourceFuncs from the ManifestsRenderer object?
    • In addition, do we know/have workarounds to it?
  • manifests_renderer.go
@inFocus7
Copy link
Contributor Author

inFocus7 commented Nov 28, 2023 •
edited
Loading

I have not labeled this, as it acts as both a question ("did we do it intentionally?") and a possible bug if not intentional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@inFocus7