Code readability and (basic) UX improvements #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elia
force-pushed
the
elia/payments-fixes
branch
from
a6fcfd3 to
f770ad5
Compare
elia
changed the title
kennyadsl
reviewed
Feb 15, 2023
templates/app/views/checkouts/steps/payment_step/_payment_method_selector.html.erb
Show resolved
Hide resolved
elia
force-pushed
the
elia/payments-fixes
branch
from
f770ad5 to
da9024d
Compare
In the order details page shown for the confirmation step and the order complete page the billing address should be more visually related to the payment.
Also show the payment state, near the payment.
elia
force-pushed
the
elia/payments-fixes
branch
from
da9024d to
fdb8f15
Compare
This was referenced Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A few marginal changes targeting code readability and basic-level/common-sense UX improvements.
Motivation and Context
Working on SolidusStripe these changes were nice-to-haves.
How Has This Been Tested?
CI
Screenshots
Types of changes
Checklist: