Add Rails 6.1.0.alpha/master support #3515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Feb 14, 2020
filippoliverani
force-pushed
the
filippoliverani/add-rails-master-support
branch
from
65f1e58 to
e448b4c
Compare
filippoliverani
force-pushed
the
filippoliverani/add-rails-master-support
branch
from
e448b4c to
50007f7
Compare
spaghetticode
approved these changes
Feb 14, 2020
kennyadsl
reviewed
Feb 18, 2020
filippoliverani
force-pushed
the
filippoliverani/add-rails-master-support
branch
from
50007f7 to
3f4b5ea
Compare
filippoliverani
force-pushed
the
filippoliverani/add-rails-master-support
branch
from
3f4b5ea to
0ab4f3e
Compare
To avoid persistence and validation issues has_many associations must be added after creation.
Add :polimorphic key option only when used to make it work with Rails 6.1+ osmaelo/rails@2c008d9 This can be removed when upgrading to an awesome_nested_set version compliant with Rails 6.1+.
Since Rails 6.1 ActiveSupport::Testing::Assertions are not auto-included by ActiveJob::TestHelper anymore.
filippoliverani
force-pushed
the
filippoliverani/add-rails-master-support
branch
from
0ab4f3e to
f53a24c
Compare
kennyadsl
approved these changes
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability to run Solidus with Rails master version.
It's useful to be able to start testing Solidus against Rails master to know what to expect and to reduce the time needed to upgrade after each Rails release.
There are also some Solidus new features that require work and that will be widely used only from Rails 6.1.0 on.
Checklist: