Lock sqlite3 version to 1.3

[mdesantis]

Fixes #3087. It includes the following changes:

Lock sqlite3 version to 1.3

ActiveRecord 5.2.2 has sqlite3 dependency locked to ~> 1.3.6, we need to reflect that in order to avoid conflicts due to sqlite3 1.4 version releasement.

Fix sqlite3 version conflict on sandbox generation

rails new generates a Gemfile with gem 'sqlite3' dependency declaration, but since sqlite3 1.4 has been released it conflicts with activerecord sqlite3 adapter dependency declaration, which is sqlite3 ~> 1.3.6.

Checklist:

• I have followed Pull Request guidelines
• I have added a detailed description into each commit message
• I have updated Guides and README accordingly to this change (if needed)
• I have added tests to cover this change (if needed)
• I have added a CHANGELOG entry for this change (if needed)

[peterberkenbosch]

sweet! I was just working on this. Trying to figure out how to "hack" the generated Gemfile. This will work!

[kennyadsl]

This has been fixed in Rails (I think just in master for now).
What do you think about this solution made on factory_bot_rails using gsub_file instead of sed?

gsub_file "Gemfile", /^gem 'sqlite3'$/, 'gem "sqlite3", "~> 1.3.6"'

I think it's a bit more "Rails friendly".

[mdesantis]

@kennyadsl I guess they have a template for the new Rails app just checked and they didn't have already a template 😞 , but we don't have it, and I wouldn't add it just for this edit. Anyway, since in lib/sandbox.sh there is also

cat <<RUBY >> Gemfile

gem 'solidus', path: '..'
gem 'solidus_auth_devise', '>= 2.1.0'
gem 'rails-i18n'
gem 'solidus_i18n'

group :test, :development do
 platforms :mri do
   gem 'pry-byebug'
 end
end
RUBY

I could convert both of them to the "Rails template way", WDYT?

[kennyadsl]

If possible, that would not be bad in my opinion. But maybe we can do that into another PR?

[mdesantis]

@kennyadsl 👍 I'll do that in another PR

[jacobherrington]

I am good with this, but what do you think about adding a comment in sandbox.sh explaining why we need to do this? Maybe we could just link to #3087.

[mdesantis]

@jacobherrington here we are! can you please check that what I wrote makes sense? I feel it could be expressed better

[jacobherrington]

LGTM!

[peterberkenbosch]

This has been fixed in Rails (I think just in master for now).
What do you think about this solution made on factory_bot_rails using gsub_file instead of sed?

gsub_file "Gemfile", /^gem 'sqlite3'$/, 'gem "sqlite3", "~> 1.3.6"'

I think it's a bit more "Rails friendly".

This is not working in sandbox.sh since it's a shell script, not a ruby file.

[kennyadsl]

@peterberkenbosch yeah, we talked about that. The only way to use gsub_file is moving that part into a Gemfile template and use that template with the -m option on the rails new command. Definitely not worth it. 🙂