Solid v1.7 #1638
Merged
Solid v1.7 #1638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Organize exports, export not exported types from signal.ts Exported types: `AccessorArray`, `EffectFunction`, `MemoOptions`, `NoInfer`, `OnEffectFunction` * Format and minor cleanup abstract `ComputationState` type, inline `get` of defined property * Rework dev hooks, add `debugValue` utility * Correct the type of `DevComponent` interface assuming the return value of `JSX.Element` is wrong, as this only applies if the component get's rendered * Correct type of `SignalState` * Add graph owner to sourceMap values * Reorder store imports * Reorder imports * Remove `afterWriteSignal` hook * add changeset --------- Co-authored-by: Ryan Carniato <[email protected]>
* Remove name generation of owners and signals * Rename SignalMapValue to SourceMapValue * add changeset --------- Co-authored-by: Ryan Carniato <[email protected]>
* Fix castError * Strongly type onError --------- Co-authored-by: Ryan Carniato <[email protected]>
* Add component funciton to dev component * Create nice-dogs-draw.md
🦋 Changeset detectedLatest commit: af34922 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Pull Request Test Coverage Report for Build 4529509779Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
@juanrgm this is expected. solid-headless is also going to be affected by this |
|
Yeah to clarify I'm expecting a bunch of errors as this is stricter. It is more trying to determine if there is any truly awkward pieces. I don't think the errors effect external facing APIs.. just internals of libraries or applications themselves. |
* Add override for babel-preset-solid * Fix external source tests by resetting modules after performing testing * Add changeset --------- Co-authored-by: Ryan Carniato <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shows the upcoming changes for Solid 1.7. You can try it out on the
nextbranch of git andbetatag on npm. It has numbering like v1.7.0-beta.3.This release has a lot of TypeScript breaking changes. We've been pretty lenient on TS breaking changes in minors so we are keeping that trend, but I'm particularly concerned with this one. So I'd appreciate the ecosystem to try it out and give some feedback leading up to the release. On the positive all the TS fixes will be backwards compatible. We've just gotten more strict with the JSX mostly, so bending to that won't break any older versions of Solid.
I will publish beta versions of related packages (like vite-plugin-solid) so that you can try this. Most packages should just work with their latest versions.