Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: reconsider color token sets #569

Closed
coraliefeil opened this issue Nov 10, 2023 · 1 comment
Closed

ci: reconsider color token sets #569

coraliefeil opened this issue Nov 10, 2023 · 1 comment
Assignees
@van-nguyen-ht
Labels
🔧 code needs changes in code 🎨 figma needs changes in Figma

Comments

@coraliefeil
Copy link
Contributor

Dev uses text color tokens only and does not differenciate between icon-fill and text.

On a semantic level we could also say it is all about foreground and background and text / icon-fill is sth that always represents a foreground.

Needs discussion and maybe changing current approach / concept.
@coraliefeil coraliefeil added 🔧 code needs changes in code 🎨 figma needs changes in Figma labels Nov 10, 2023
@coraliefeil coraliefeil mentioned this issue Nov 10, 2023
Merged
5 tasks
@karlbaumhauer karlbaumhauer transferred this issue from another repository Nov 14, 2023
@karlbaumhauer karlbaumhauer transferred this issue from solid-design-system/ticket-temp Nov 14, 2023
@coraliefeil
Copy link
Contributor Author

Discussion has taken place. The dept can be translated in DEV - for e.g. sd-interactive.

No need to rework current/aligned token structure.

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Solid Design System Project Board Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@van-nguyen-ht van-nguyen-ht

Labels
🔧 code needs changes in code 🎨 figma needs changes in Figma
Projects
Solid Design System Project Board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@coraliefeil @van-nguyen-ht