Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ✨ add sd-checkbox & sd-checkbox-group #257

Closed
9 tasks done
Tracked by #242
mariohamann opened this issue Jul 26, 2023 · 5 comments · Fixed by #507
Closed
9 tasks done
Tracked by #242

feat: ✨ add sd-checkbox & sd-checkbox-group #257

mariohamann opened this issue Jul 26, 2023 · 5 comments · Fixed by #507
Assignees
@DanielHargesheimer
Labels
CL-migration All components which need to be migrated from Component Library 🔧 code needs changes in code
Milestone
2023-11-28

Comments

@mariohamann
Copy link
Contributor

mariohamann commented Jul 26, 2023 •
edited by DanielHargesheimer
Loading

User Story

As a user of the Solid Design System, I want to use a checkbox component with various features and styling options, so that I can create intuitive and customizable form elements that enhance the user experience.

Components detailed requirements

API

https://www.figma.com/file/VTztxQ5pWG7ARg8hCX6PfR/Solid-DS-%E2%80%93-Component-Library?type=design&node-id=88-1057&mode=design

Hand-off

https://www.figma.com/file/Q7E9GTBET7Gs2HyH1kbpu5/Checkbox-%2F-Checkbox-Group?type=design&node-id=6-4&mode=design

Documentation

https://www.figma.com/file/Q7E9GTBET7Gs2HyH1kbpu5/Checkbox-%2F-Checkbox-Group?type=design&node-id=0-1&mode=design

DoR

  • Item has business value
  • Item has been estimated by the team
  • Item is clear and well-defined
  • Item dependencies have been identified

DoD

  • Documentation has been created/updated (if applicable)
  • Migration Guide has been created/updated (if applicable)
  • Relevant E2E tests (Features, A11y, Bug fixes) are created/updated
  • Relevant stories (Features, A11y) are created/updated
  • Implementation works successfully on feature branch
@mariohamann mariohamann mentioned this issue Jul 26, 2023
Closed
8 tasks
@coraliefeil coraliefeil moved this from 📋 Backlog to To be refined in Solid Design System Project Board Aug 16, 2023
@yoezlem yoezlem changed the title feat: ✨ add sd-checkbox feat: ✨ add sd-checkbox & sd-checkbox-group Sep 28, 2023
@yoezlem yoezlem moved this from To be refined to 🔖 Ready in Solid Design System Project Board Sep 29, 2023
@karlbaumhauer karlbaumhauer mentioned this issue Oct 4, 2023
Closed
25 tasks
@karlbaumhauer karlbaumhauer moved this from 🔖 Ready to 🏗 In progress in Solid Design System Project Board Oct 12, 2023
@karlbaumhauer karlbaumhauer added this to the MVP form elements milestone Oct 20, 2023
@karlbaumhauer
Copy link
Contributor

@mariohamann pls specify the required prop and behavior

@coraliefeil
Copy link
Contributor

prop name should be "error-text"

@karlbaumhauer karlbaumhauer moved this from 🏗 In progress to 🛠️ To be pre-refined in Solid Design System Project Board Oct 25, 2023
@karlbaumhauer
Copy link
Contributor

karlbaumhauer commented Oct 25, 2023 •
edited
Loading

result from the pre-refinement:

  • hints will be renamed to help-text
  • error-text will show up (additionally) below the input field => watch out for a11y (https://shoelace.style/getting-started/form-controls#inline-form-validation)
  • success-text will be removed
  • sd-checkbox-group will only have a label (slot), help-text (slot), error-text (string-prop) and a status (error/success) to be set manually by the user

needs to be replaced in this ticket, #255, #12 & #216 => also in all respective figma issues.

@karlbaumhauer karlbaumhauer moved this from 🛠️ To be pre-refined to 🏗 In progress in Solid Design System Project Board Oct 25, 2023
@abudd1094
Copy link
Contributor

image
from #255 (:

@karlbaumhauer
Copy link
Contributor

image from #255 (:

yeah... I know... we had a nice back and forth on this but finally (fingers crossed) agreed on this now.

@karlbaumhauer karlbaumhauer removed their assignment Oct 26, 2023
@DanielHargesheimer DanielHargesheimer moved this from 🏗 In progress to 👀 In review in Solid Design System Project Board Oct 30, 2023
@DanielHargesheimer DanielHargesheimer linked a pull request Nov 2, 2023 that will close this issue
feat: ✨ sd-checkbox & sd-checkbox-group #507
Merged
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Solid Design System Project Board Nov 10, 2023
@yoezlem yoezlem added 🔧 code needs changes in code CL-migration All components which need to be migrated from Component Library labels Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanielHargesheimer DanielHargesheimer

Labels
CL-migration All components which need to be migrated from Component Library 🔧 code needs changes in code
Projects
Solid Design System Project Board
Archived in project
Milestone
2023-11-28
Development

Successfully merging a pull request may close this issue.

feat: ✨ sd-checkbox & sd-checkbox-group solid-design-system/solid
6 participants
@DanielHargesheimer @mariohamann @abudd1094 @coraliefeil @karlbaumhauer @yoezlem