Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[dev]: ✨ implement A11y improvements to sd-flag #1611

Open
3 of 10 tasks
yoezlem opened this issue Nov 4, 2024 · 0 comments
Open
3 of 10 tasks

feat[dev]: ✨ implement A11y improvements to sd-flag #1611

yoezlem opened this issue Nov 4, 2024 · 0 comments
Labels
A11y Audit Identifies tasks related to accessibility improvements identified in the A11y audit of the DS 🔧 code needs changes in code Critical A11y Issue Require immediate attention and resolution Subtask Epic subtasks

Comments

@yoezlem
Copy link
Contributor

yoezlem commented Nov 4, 2024

Description

This task describes the Storybook implementation for the sd-flag component as part of the A11y improvements outlined in Epic #1465.

A11y improvements for sd-step-group and sd-step can be found here: sd-flag Notes.


Comment

Problem: The contrast ratio in sd-flag--neutral-500 is not high enough (2.21:1).
Solution: Use a ratio of at least 4.5:1.

Note

  • The heading in a teaser should be the first item in the DOM. A heading introduces a new thematic region and separates the following content from the previous region. Although chips and flags are visually the first items in the teaser, they should come after the heading in the DOM.

Related WCAG criteria

Template Ticket

DoR

  • Item has business value
  • Item has been estimated by the team
  • Item is clear and well-defined
  • Item dependencies have been identified

DoD

  • Documentation has been created/updated (if applicable)
  • Migration Guide has been created/updated (if applicable)
  • Relevant E2E tests (Features, A11y, Bug fixes) are created/updated
  • Relevant stories (Features, A11y) are created/updated
  • Implementation works successfully on feature branch
@yoezlem yoezlem added 🔧 code needs changes in code A11y Audit Identifies tasks related to accessibility improvements identified in the A11y audit of the DS Critical A11y Issue Require immediate attention and resolution Subtask Epic subtasks labels Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11y Audit Identifies tasks related to accessibility improvements identified in the A11y audit of the DS 🔧 code needs changes in code Critical A11y Issue Require immediate attention and resolution Subtask Epic subtasks
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant