Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sd-badge variant names a11y update #1593

Open
7 tasks
smfonseca opened this issue Oct 25, 2024 · 0 comments
Open
7 tasks

feat: sd-badge variant names a11y update #1593

smfonseca opened this issue Oct 25, 2024 · 0 comments
Assignees
Labels
BREAKING CHANGE all issues which end up in a breaking change 🔧 code needs changes in code 🙌 Epic

Comments

@smfonseca
Copy link
Contributor

User Story

Problem: In the docs, it says that the success and error variants don't imply any semantic meaning. They kinda do because they tell me that something good, bad, or neutral is going on. You can argue that the number itself is enough to communicate that information, at least as a fallback, but that's not the case in the sm variation. It only communicates the state visually.

Solution:

  • Extend the hint to make clear why we have the variant names
  •  Change variants names from to blue, red and green to avoid connotations

Discussion regarding this change can be found here.

DoR

  • Item has business value
  • Item all subtasks have been estimated by the team
  • Item is clear and well-defined
  • Item dependencies have been identified

DoD

  • All subtasks have been closed
@smfonseca smfonseca added 🙌 Epic 🔧 code needs changes in code BREAKING CHANGE all issues which end up in a breaking change labels Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE all issues which end up in a breaking change 🔧 code needs changes in code 🙌 Epic
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants