From 5eb3069ce61602facc862fdc97208f04a65329a1 Mon Sep 17 00:00:00 2001 From: Sergio Fonseca <42741644+smfonseca@users.noreply.github.com> Date: Thu, 12 Dec 2024 11:22:45 +0000 Subject: [PATCH 1/3] fix: correctly order bundle stats (#1726) ## Description: The PR fixes the order in which the bundle stats should show up in the packages changelog. ## Definition of Reviewable: - [ ] Documentation is created/updated - [ ] Migration Guide is created/updated - [ ] E2E tests (features, a11y, bug fixes) are created/updated - [ ] Stories (features, a11y) are created/updated - [ ] relevant tickets are linked --- .changeset/dry-sloths-tease.md | 2 ++ packages/components/CHANGELOG.md | 22 +++++++++---------- .../components/scripts/node-write-sizes.mjs | 18 ++++++++++----- 3 files changed, 24 insertions(+), 18 deletions(-) create mode 100644 .changeset/dry-sloths-tease.md diff --git a/.changeset/dry-sloths-tease.md b/.changeset/dry-sloths-tease.md new file mode 100644 index 000000000..a845151cc --- /dev/null +++ b/.changeset/dry-sloths-tease.md @@ -0,0 +1,2 @@ +--- +--- diff --git a/packages/components/CHANGELOG.md b/packages/components/CHANGELOG.md index 9749d88b7..ac00b697c 100644 --- a/packages/components/CHANGELOG.md +++ b/packages/components/CHANGELOG.md @@ -1,8 +1,4 @@ -### 📈 Stats -* Uncompressed: 440 KB (+1 KB / +0%) -* Gzipped: 132 KB (unchanged) - -### 📈 Stats +# @solid-design-system/components ## 3.23.1 @@ -13,10 +9,9 @@ - Correctly label icon-button dropdown triggers. - Fix focus on the trigger after the dropdown is hidden using the keyboard. -* Uncompressed: 439 KB (+29 KB / +7%) -* Gzipped: 132 KB (+7 KB / +6%) - ### 📈 Stats +* Uncompressed: 440 KB (+1 KB / +0%) +* Gzipped: 132 KB (unchanged) ## 3.23.0 @@ -33,10 +28,9 @@ - show tags in selected order - add sd-optgroup component for better grouping of options -* Uncompressed: 410 KB (+1 KB / +0%) -* Gzipped: 125 KB (unchanged) - -# @solid-design-system/components +### 📈 Stats +* Uncompressed: 439 KB (+29 KB / +7%) +* Gzipped: 132 KB (+7 KB / +6%) ## 3.22.18 @@ -47,6 +41,10 @@ - Implemented `aria-invalid` attribute to semantically indicate component validity. - Implemented live announcement to screen readers when a tag is removed. +### 📈 Stats +* Uncompressed: 410 KB (+1 KB / +0%) +* Gzipped: 125 KB (unchanged) + ## 3.22.17 ### Patch Changes diff --git a/packages/components/scripts/node-write-sizes.mjs b/packages/components/scripts/node-write-sizes.mjs index 9d821b720..8e5181b02 100644 --- a/packages/components/scripts/node-write-sizes.mjs +++ b/packages/components/scripts/node-write-sizes.mjs @@ -42,13 +42,19 @@ fs.readFile('./CHANGELOG.md', 'utf8', (err, data) => { let result; - if (data.startsWith(newVersionHeader)) { - // If the new version header exists, find the next version header and insert the content before it + if (data.includes(newVersionHeader)) { + // If the new version header exists, find the next version header and insert content before it let replaced = false; - result = data.replace(nextVersionHeaderRegex, (match, offset) => { - if (offset === 0 || replaced) return match; // Ignore the first match (new version header) and any matches after the first replacement - replaced = true; - return additionalContent + match; + result = data.replace(nextVersionHeaderRegex, (match, offset, string) => { + // Replace only after the new version header + const isAfterNewVersion = string.indexOf(newVersionHeader) < offset && !replaced; + + if (isAfterNewVersion) { + replaced = true; + return additionalContent + match; + } + + return match; }); } else { // If the new version header doesn't exist, insert the content at the start of the file From 203a8d83a69cba68df64ae5880a06c7927d4dcd9 Mon Sep 17 00:00:00 2001 From: Paulo Vareiro <58229468+paulovareiro29@users.noreply.github.com> Date: Thu, 12 Dec 2024 14:18:16 +0000 Subject: [PATCH 2/3] fix: improve sd-carousel template alt descriptions (#1725) ## Description: Closes #1513 ## Definition of Reviewable: - [x] Documentation is created/updated - [x] Stories (features, a11y) are created/updated - [x] relevant tickets are linked --- .changeset/ten-buckets-hide.md | 5 +++ .../src/stories/templates/carousel.stories.ts | 36 +++++++++++++++---- 2 files changed, 35 insertions(+), 6 deletions(-) create mode 100644 .changeset/ten-buckets-hide.md diff --git a/.changeset/ten-buckets-hide.md b/.changeset/ten-buckets-hide.md new file mode 100644 index 000000000..26cdbb215 --- /dev/null +++ b/.changeset/ten-buckets-hide.md @@ -0,0 +1,5 @@ +--- +'@solid-design-system/docs': patch +--- + +Improve carousel template alt descriptions diff --git a/packages/docs/src/stories/templates/carousel.stories.ts b/packages/docs/src/stories/templates/carousel.stories.ts index 28a724b8b..869bedfba 100644 --- a/packages/docs/src/stories/templates/carousel.stories.ts +++ b/packages/docs/src/stories/templates/carousel.stories.ts @@ -18,13 +18,25 @@ export const CarouselWithImages = { render: () => html` - architecture + Modern, waved architecture with blue sky in background - skyline + A vibrant city skyline at dusk, symbolizing economic growth and investment opportunities in urban hubs. - workspace + Close-up of a pair of glasses, a pen, and an open notebook with notes written on it, on a desk next to a laptop. ` @@ -35,13 +47,25 @@ export const LoopAndAutoplay = { render: () => html` - coffeeshop + A group of people sitting in a coffee shop - friends + A couple of friends sitting and laughing together on a bed with a dog. - family + A smiling father with two children outdoors, symbolizing shared values and future growth. ` From 46303b6e670bbcae4927804158c1880b7c128aef Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" Date: Thu, 12 Dec 2024 14:19:09 +0000 Subject: [PATCH 3/3] chore(release): docs@1.2.1 [skip actions] --- .changeset/dry-sloths-tease.md | 2 -- .changeset/ten-buckets-hide.md | 5 ----- packages/docs/CHANGELOG.md | 6 ++++++ packages/docs/package.json | 2 +- 4 files changed, 7 insertions(+), 8 deletions(-) delete mode 100644 .changeset/dry-sloths-tease.md delete mode 100644 .changeset/ten-buckets-hide.md diff --git a/.changeset/dry-sloths-tease.md b/.changeset/dry-sloths-tease.md deleted file mode 100644 index a845151cc..000000000 --- a/.changeset/dry-sloths-tease.md +++ /dev/null @@ -1,2 +0,0 @@ ---- ---- diff --git a/.changeset/ten-buckets-hide.md b/.changeset/ten-buckets-hide.md deleted file mode 100644 index 26cdbb215..000000000 --- a/.changeset/ten-buckets-hide.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'@solid-design-system/docs': patch ---- - -Improve carousel template alt descriptions diff --git a/packages/docs/CHANGELOG.md b/packages/docs/CHANGELOG.md index 38c7a3820..c6c89d4de 100644 --- a/packages/docs/CHANGELOG.md +++ b/packages/docs/CHANGELOG.md @@ -1,5 +1,11 @@ # @solid-design-system/docs +## 1.2.1 + +### Patch Changes + +- Improve carousel template alt descriptions _[`#1725`](https://github.com/solid-design-system/solid/pull/1725) [`203a8d8`](https://github.com/solid-design-system/solid/commit/203a8d83a69cba68df64ae5880a06c7927d4dcd9) [@paulovareiro29](https://github.com/paulovareiro29)_ + ## 1.2.0 ### Minor Changes diff --git a/packages/docs/package.json b/packages/docs/package.json index 2bc10f55e..28f473e80 100644 --- a/packages/docs/package.json +++ b/packages/docs/package.json @@ -2,7 +2,7 @@ "name": "@solid-design-system/docs", "description": "This package provides the documentation for the Solid Design System.", "homepage": "https://solid-design-system.fe.union-investment.de/docs/", - "version": "1.2.0", + "version": "1.2.1", "author": { "name": "Union Investment" },