Merge branch 'main' of github.com:solid-design-system/solid into fix/…

…improve-sd-expandable-a11y
solid-design-system · Dec 12, 2024 · 1494f5f · 1494f5f
2 parents ec9379b + 46303b6
commit 1494f5f
Show file tree

Hide file tree

Showing 5 changed files with 59 additions and 25 deletions.
diff --git a/packages/components/CHANGELOG.md b/packages/components/CHANGELOG.md
@@ -1,8 +1,4 @@
-### 📈 Stats
-* Uncompressed: 440 KB (+1 KB / +0%)
-* Gzipped: 132 KB (unchanged)
-
-### 📈 Stats
+# @solid-design-system/components
 
 ## 3.23.1
 
@@ -13,10 +9,9 @@
   - Correctly label icon-button dropdown triggers.
   - Fix focus on the trigger after the dropdown is hidden using the keyboard.
 
-* Uncompressed: 439 KB (+29 KB / +7%)
-* Gzipped: 132 KB (+7 KB / +6%)
-
 ### 📈 Stats
+* Uncompressed: 440 KB (+1 KB / +0%)
+* Gzipped: 132 KB (unchanged)
 
 ## 3.23.0
 
@@ -33,10 +28,9 @@
   - show tags in selected order
   - add sd-optgroup component for better grouping of options
 
-* Uncompressed: 410 KB (+1 KB / +0%)
-* Gzipped: 125 KB (unchanged)
-
-# @solid-design-system/components
+### 📈 Stats
+* Uncompressed: 439 KB (+29 KB / +7%)
+* Gzipped: 132 KB (+7 KB / +6%)
 
 ## 3.22.18
 
@@ -47,6 +41,10 @@
   - Implemented `aria-invalid` attribute to semantically indicate component validity.
   - Implemented live announcement to screen readers when a tag is removed.
 
+### 📈 Stats
+* Uncompressed: 410 KB (+1 KB / +0%)
+* Gzipped: 125 KB (unchanged)
+
 ## 3.22.17
 
 ### Patch Changes

diff --git a/packages/components/scripts/node-write-sizes.mjs b/packages/components/scripts/node-write-sizes.mjs
@@ -42,13 +42,19 @@ fs.readFile('./CHANGELOG.md', 'utf8', (err, data) => {
 
   let result;
 
-  if (data.startsWith(newVersionHeader)) {
-    // If the new version header exists, find the next version header and insert the content before it
+  if (data.includes(newVersionHeader)) {
+    // If the new version header exists, find the next version header and insert content before it
     let replaced = false;
-    result = data.replace(nextVersionHeaderRegex, (match, offset) => {
-      if (offset === 0 || replaced) return match; // Ignore the first match (new version header) and any matches after the first replacement
-      replaced = true;
-      return additionalContent + match;
+    result = data.replace(nextVersionHeaderRegex, (match, offset, string) => {
+      // Replace only after the new version header
+      const isAfterNewVersion = string.indexOf(newVersionHeader) < offset && !replaced;
+
+      if (isAfterNewVersion) {
+        replaced = true;
+        return additionalContent + match;
+      }
+
+      return match;
     });
   } else {
     // If the new version header doesn't exist, insert the content at the start of the file

diff --git a/packages/docs/CHANGELOG.md b/packages/docs/CHANGELOG.md
@@ -1,5 +1,11 @@
 # @solid-design-system/docs
 
+## 1.2.1
+
+### Patch Changes
+
+- Improve carousel template alt descriptions _[`#1725`](https://github.com/solid-design-system/solid/pull/1725) [`203a8d8`](https://github.com/solid-design-system/solid/commit/203a8d83a69cba68df64ae5880a06c7927d4dcd9) [@paulovareiro29](https://github.com/paulovareiro29)_
+
 ## 1.2.0
 
 ### Minor Changes

diff --git a/packages/docs/package.json b/packages/docs/package.json
@@ -2,7 +2,7 @@
   "name": "@solid-design-system/docs",
   "description": "This package provides the documentation for the Solid Design System.",
   "homepage": "https://solid-design-system.fe.union-investment.de/docs/",
-  "version": "1.2.0",
+  "version": "1.2.1",
   "author": {
     "name": "Union Investment"
   },

diff --git a/packages/docs/src/stories/templates/carousel.stories.ts b/packages/docs/src/stories/templates/carousel.stories.ts
@@ -18,13 +18,25 @@ export const CarouselWithImages = {
   render: () => html`
     <sd-carousel>
       <sd-carousel-item>
-        <img src="./placeholders/images/architecture.jpg" alt="architecture" class="aspect-video" />
+        <img
+          src="./placeholders/images/architecture.jpg"
+          alt="Modern, waved architecture with blue sky in background"
+          class="aspect-video"
+        />
       </sd-carousel-item>
       <sd-carousel-item>
-        <img src="./placeholders/images/skyline.jpg" alt="skyline" class="aspect-video" />
+        <img
+          src="./placeholders/images/skyline.jpg"
+          alt="A vibrant city skyline at dusk, symbolizing economic growth and investment opportunities in urban hubs."
+          class="aspect-video"
+        />
       </sd-carousel-item>
       <sd-carousel-item>
-        <img src="./placeholders/images/workspace.jpg" alt="workspace" class="aspect-video" />
+        <img
+          src="./placeholders/images/workspace.jpg"
+          alt="Close-up of a pair of glasses, a pen, and an open notebook with notes written on it, on a desk next to a laptop."
+          class="aspect-video"
+        />
       </sd-carousel-item>
     </sd-carousel>
   `
@@ -35,13 +47,25 @@ export const LoopAndAutoplay = {
   render: () => html`
     <sd-carousel loop autoplay>
       <sd-carousel-item>
-        <img src="./placeholders/images/coffeeshop.jpg" alt="coffeeshop" class="aspect-video" />
+        <img
+          src="./placeholders/images/coffeeshop.jpg"
+          alt="A group of people sitting in a coffee shop"
+          class="aspect-video"
+        />
       </sd-carousel-item>
       <sd-carousel-item>
-        <img src="./placeholders/images/friends.jpg" alt="friends" class="aspect-video" />
+        <img
+          src="./placeholders/images/friends.jpg"
+          alt="A couple of friends sitting and laughing together on a bed with a dog."
+          class="aspect-video"
+        />
       </sd-carousel-item>
       <sd-carousel-item>
-        <img src="./placeholders/images/family.jpg" alt="family" class="aspect-video" />
+        <img
+          src="./placeholders/images/family.jpg"
+          alt="A smiling father with two children outdoors, symbolizing shared values and future growth."
+          class="aspect-video"
+        />
       </sd-carousel-item>
     </sd-carousel>
   `