Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go versions, dependencies #31

Merged
merged 5 commits into from
Nov 14, 2023
Merged

Update Go versions, dependencies #31

merged 5 commits into from
Nov 14, 2023

Conversation

swi-jared
Copy link
Contributor

No description provided.

@swi-jared swi-jared changed the title Update dependencies Update Go versions, dependencies Nov 13, 2023
@swi-jared swi-jared marked this pull request as ready for review November 13, 2023 21:55
@swi-jared swi-jared requested a review from a team as a code owner November 13, 2023 21:55
@cheempz
Copy link
Contributor

cheempz commented Nov 14, 2023

Thanks @swi-jared! There are a couple changes from upstream that I'm not sure if impacts our SDK and/or examples: open-telemetry/opentelemetry-go#4620, open-telemetry/opentelemetry-go-contrib#4534

@swi-jared
Copy link
Contributor Author

@cheempz Regarding open-telemetry/opentelemetry-go-contrib#4534, I recall in the SIG there was some discussion about keeping the current interceptors because the new stats handlers are marked as experimental, and thus subject to change. For now I'm happy to keep things as they are, but ultimately I don't feel strongly.

Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@swi-jared swi-jared merged commit 13a142c into main Nov 14, 2023
4 checks passed
@swi-jared swi-jared deleted the dep-updates branch November 14, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants