Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bench-tps: allow option to not set account data size on every transaction #35443

Closed
wants to merge 1 commit into from
Closed

Conversation

anwayde
Copy link
Contributor

@anwayde anwayde commented Mar 12, 2024

Problem

Bench TPS needs this feature activated on the cluster since all transactions are hardcoded to include the instruction to set the account data size. However, this will not work on a test cluster where this feature is not activated. Moreover, Firedancer currently does not support that instruction.

Summary of Changes

This adds a flag --skip-tx-account-data-size which when specified, will not add that instruction. This makes Bench TPS work with FIredancer (and Solana clusters without any features activated).

Fixes #

Copy link
Collaborator

@anza-team anza-team left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! This repository is no longer in use. Please re-open this pull request in the agave repo: https://github.com/anza-xyz/agave

@anza-team anza-team closed this Mar 12, 2024
@mergify mergify bot added community Community contribution need:merge-assist labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution need:merge-assist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants