add compute budget instruction to set loaded accounts data size limit #30377

tao-stones · 2023-02-16T22:15:21Z

Problem

Need instruction for users to set per transaction accounts data size limit

Summary of Changes

add compute budget instruction, with 64MB as Max (current hard coded limit)
feature gated
updated call sites

Feature Gate Issue: #30366

tao-stones

Soliciting inputs:

sdk/src/compute_budget.rs

runtime/src/transaction_priority_details.rs

program-runtime/src/compute_budget.rs

brooksprumo

After working on various issues related to setting maximum allocation limits [1], would it beneficial to be more explicit with the names to indicate these limits/instructions are for loading account data (not allocating)?

Or/also, do you anticipate a similar instruction/limit for requesting/setting an allocation limit?

[1] #27375

tao-stones · 2023-02-22T22:49:52Z

would it beneficial to be more explicit with the names to indicate these limits/instructions are for loading account data (not allocating)?

Good call, renamed to be explicit

Or/also, do you anticipate a similar instruction/limit for requesting/setting an allocation limit?

afaik there is no plan for it yet. It is possible to add another instruction to allow request allocation limit when needed.

…BYTES

brooksprumo

I can't find where the load limit is used. Is that already implemented, or will that come in a future PR?

docs/src/developing/programming-model/runtime.md

program-runtime/src/compute_budget.rs

docs/src/developing/programming-model/runtime.md

brooksprumo

I can't find where the load limit is used. Is that already implemented, or will that come in a future PR?

tao-stones · 2023-02-24T01:36:14Z

I can't find where the load limit is used. Is that already implemented, or will that come in a future PR?

currently the limit is hardcoded 64M at here. This PR is to introduce the request ix, after it's landed, will have a follow up PR to replace the hardcoded 64MB with the ix. The overarching goal is to charge payer for the bytes requested to loaded. If user doesn't specify the loaded data limit, then 64MB is used, and charged accordingly. To reduce cost, user can use this instruction to request lesser (and more accurate) bytes per tx.

brooksprumo

lgtm

t-nelson · 2023-03-09T23:00:45Z

sdk/src/compute_budget.rs

@@ -41,6 +41,8 @@ pub enum ComputeBudgetInstruction {
    /// Set a compute unit price in "micro-lamports" to pay a higher transaction
    /// fee for higher transaction prioritization.
    SetComputeUnitPrice(u64),
+    /// Set a specific transaction-wide account data size limit, in bytes, is allowed to load.
+    SetLoadedAccountsDataSizeLimit(u32),


sad because no TLV here? I bounced around the idea with multiple parties, as I wasn't fully convinced that mixed use of TLV and whatever-we-have will be satisfying. The consensus is mainly on "less programs, more instructions per program". So i decided to keep this program consistent in style, leave TLV to next new program (say ApplicationFee :D )

TLV means what?

TLV means what?

i had proposed that we stop adding new compute budget instructions for each requestable parameter and instead add one final compute budget instruction that takes as data a TLV structure similar to what token22 uses for extensions. idea here being that the instructions add both space and compute overhead to transactions and their process. also, in a future transaction format version, the TLV structure could be made a first-class citizen, eliminating the need for compute budget instructions and the compute budget program at all

…solana-labs#30377) * add compute budget instruction to set accounts data size limit * changes names to explicitly for loaded accounts data size

tao-stones added the feature-gate Pull Request adds or modifies a runtime feature gate label Feb 16, 2023

tao-stones force-pushed the feature-add-instruction-set-tx-data-size branch from 7217688 to db2716d Compare February 16, 2023 22:19

tao-stones commented Feb 16, 2023

View reviewed changes

sdk/src/compute_budget.rs Outdated Show resolved Hide resolved

runtime/src/transaction_priority_details.rs Show resolved Hide resolved

program-runtime/src/compute_budget.rs Outdated Show resolved Hide resolved

tao-stones force-pushed the feature-add-instruction-set-tx-data-size branch 2 times, most recently from 9537944 to 364ee9f Compare February 17, 2023 17:02

tao-stones requested a review from brooksprumo February 17, 2023 21:19

brooksprumo reviewed Feb 21, 2023

View reviewed changes

tao-stones force-pushed the feature-add-instruction-set-tx-data-size branch from 364ee9f to e6b2efc Compare February 22, 2023 22:07

tao-stones added 2 commits February 22, 2023 16:44

add compute budget instruction to set accounts data size limit

7778591

changes names to explicitly for loaded accounts data size

aee61cb

tao-stones force-pushed the feature-add-instruction-set-tx-data-size branch from 0889e9b to aee61cb Compare February 22, 2023 22:44

tao-stones added 2 commits February 22, 2023 16:55

replace DEFAULT_ACCOUNTS_DATA_SIZE_BYTES with MAX_ACCOUNTS_DATA_SIZE_…

3af8e2f

…BYTES

fmt

f4a5fe4

tao-stones requested review from brooksprumo and Lichtso February 23, 2023 14:44

Lichtso changed the title ~~add compute budget instruction to set accounts data size limit~~ add compute budget instruction to set loaded accounts data size limit Feb 23, 2023

brooksprumo reviewed Feb 23, 2023

View reviewed changes

docs/src/developing/programming-model/runtime.md Outdated Show resolved Hide resolved

program-runtime/src/compute_budget.rs Show resolved Hide resolved

update doc

e5619ca

tao-stones requested a review from brooksprumo February 23, 2023 20:31

brooksprumo reviewed Feb 23, 2023

View reviewed changes

docs/src/developing/programming-model/runtime.md Outdated Show resolved Hide resolved

brooksprumo reviewed Feb 23, 2023

View reviewed changes

fix names in doc

e4dd5a0

tao-stones requested a review from brooksprumo February 24, 2023 01:36

brooksprumo approved these changes Feb 24, 2023

View reviewed changes

tao-stones merged commit 66ea750 into solana-labs:master Feb 24, 2023

t-nelson reviewed Mar 9, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add compute budget instruction to set loaded accounts data size limit #30377

add compute budget instruction to set loaded accounts data size limit #30377

tao-stones commented Feb 16, 2023

tao-stones left a comment

brooksprumo left a comment

tao-stones commented Feb 22, 2023

brooksprumo left a comment

brooksprumo left a comment •

edited

Loading

tao-stones commented Feb 24, 2023

brooksprumo left a comment

t-nelson Mar 9, 2023

tao-stones Mar 10, 2023

mschneider Mar 10, 2023

t-nelson Mar 10, 2023

add compute budget instruction to set loaded accounts data size limit #30377

add compute budget instruction to set loaded accounts data size limit #30377

Conversation

tao-stones commented Feb 16, 2023

Problem

Summary of Changes

tao-stones left a comment

Choose a reason for hiding this comment

brooksprumo left a comment

Choose a reason for hiding this comment

tao-stones commented Feb 22, 2023

brooksprumo left a comment

Choose a reason for hiding this comment

brooksprumo left a comment • edited Loading

Choose a reason for hiding this comment

tao-stones commented Feb 24, 2023

brooksprumo left a comment

Choose a reason for hiding this comment

t-nelson Mar 9, 2023

Choose a reason for hiding this comment

tao-stones Mar 10, 2023

Choose a reason for hiding this comment

mschneider Mar 10, 2023

Choose a reason for hiding this comment

t-nelson Mar 10, 2023

Choose a reason for hiding this comment

brooksprumo left a comment •

edited

Loading