Extract process_ledger from Bank #2785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fullnode was the only real consumer of process_ledger and it was only there to process a Blocktree. Blocktree is a tree, and a ledger is a sequence, so something's clearly not right here. Drop all other dependencies on process_ledger (only one test) so that it can be fixed up in isolation.
garious
force-pushed
the
boot-process_ledger
branch
from
76c2245 to
52c27be
Compare
Codecov Report
@@ Coverage Diff @@
## master #2785 +/- ##
========================================
- Coverage 78.5% 78.5% -0.1%
========================================
Files 119 120 +1
Lines 19508 19505 -3
========================================
- Hits 15333 15325 -8
- Misses 4175 4180 +5 |
steviez
added a commit
to steviez/solana
that referenced
this pull request
Aug 29, 2024
These counters should be removed for several reasons: - Counters in general are bad (multiple atomics for a single value) - The counters are at debug level, so effectively unused - The reported values can be determined from SigVerifierStats The only thing lost is whether verification was done by cpu/gpu/disabled verifier. But, most validators are not running gpu's, so ripping this out now and it can be re-added more properly if more validators shift to using gpu's.
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Aug 29, 2024
These counters should be removed for several reasons: - Counters in general are bad (multiple atomics for a single value) - The counters are at debug level, so effectively unused - The reported values can be determined from SigVerifierStats The only thing lost is whether verification was done by cpu/gpu/disabled verifier. But, most validators are not running gpu's, so ripping this out now and it can be re-added more properly if more validators shift to using gpu's.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fullnode was the only real consumer of process_ledger and it was
only there to process a Blocktree. Blocktree is a tree, and a
ledger is a sequence, so something's clearly not right here.
Summary of Changes