-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup tpu/tvu runtime description in the runtime chapter. #2737
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,10 @@ | ||
.------------. .-----------. .---------------. .--------------. .-----------------------. | ||
| PoH verify +---> | sigverify +--->| lock accounts +--->| validate fee +--->| allocate new accounts +---> | ||
| TVU | `-----------` `---------------` `--------------` `-----------------------` | ||
`------------` | ||
|
||
.-----------. .-------------. .--------------. .--------------------. | ||
| sigverify +--->| lock memory +--->| validate fee +--->| allocate accounts +---> | ||
`-----------` `-------------` `--------------` `--------------------` | ||
|
||
.------------. .---------. .--------. .--------------. .--------------. | ||
--->| load data +--->| execute +--->| record +--->| commit data +-->|unlock memory | | ||
`------------` `---------` `--------` `--------------` `--------------` | ||
.---------------. .---------. .------------. .-----------------. .-----------------. | ||
--->| load accounts +--->| execute +--->| PoH record +--->| commit accounts +-->| unlock accounts | | ||
`---------------` `---------` | TPU | `-----------------` `-----------------` | ||
`------------` | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not following this rule, what is it trying to accomplish?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jackcmay thats the current design, the account has a owner program id, only the owner program id can modify the account userdata byte array.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that means that a program has a guarantee that the program code is the only thing that can transition state in the accounts that it owns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I get that part but rule #1's second part is confusing and muddles up the first part. How about:
"1. Each account is
owned
and modifiable by only one program at a time."For the second half are you saying that when an account is assigned it's user data is zero'd?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jackcmay yes! :), and cannot be reassigned.