Generate packet offsets for versioned messages

[jstarry]

Problem

Sigverify does not support getting the correct packet offsets for the new versioned transactions.

Summary of Changes

Add detection for the message version prefix to properly handle versioned transactions in sigverify

Fixes #

[jstarry]

downstream failure is unrelated to this change, this is ready for review!

[codecov]

Codecov Report

Merging #19138 (12fc4cd) into master (8817f59) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

❗ Current head 12fc4cd differs from pull request most recent head 691cf1a. Consider uploading reports for the commit 691cf1a to get more accurate results

@@            Coverage Diff            @@
##           master   #19138     +/-   ##
=========================================
- Coverage    82.9%    82.8%   -0.1%     
=========================================
  Files         453      453             
  Lines      128700   128723     +23     
=========================================
- Hits       106715   106673     -42     
- Misses      21985    22050     +65     

[t-nelson]

lgtm! It might be nice to adjust this a bit so the inevitable v1 in a smaller change set. I won't block on that though

[jstarry]

It might be nice to adjust this a bit so the inevitable v1 in a smaller change set. I won't block on that though

Can you elaborate on what you mean here? I intend to have versioning start at 0

[t-nelson]

Can you elaborate on what you mean here? I intend to have versioning start at 0

Sure! My idea was just to set this code up so the addition of future versions is obvious. Basically just a minor rework to a match over the version number and v0's implementation stuck under the corresponding arm

[jstarry]

Sure! My idea was just to set this code up so the addition of future versions is obvious. Basically just a minor rework to a match over the version number and v0's implementation stuck under the corresponding arm

Ah, got it. Good call, updated.

Pull request has been modified.

[t-nelson]

re-re-lgtm!