Correct Bank timestamp drift every slot #12737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12737 +/- ##
========================================
Coverage 81.9% 81.9%
========================================
Files 359 360 +1
Lines 84547 84686 +139
========================================
+ Hits 69277 69412 +135
- Misses 15270 15274 +4 |
CriesofCarrots
force-pushed
the
correct-every-bank-timestamp
branch
from
0261ec7
to
aa966f3
Compare
mvines
reviewed
Oct 9, 2020
garious
previously approved these changes
Oct 9, 2020
mergify
bot
dismissed stale reviews from mvines and garious
Pull request has been modified.
CriesofCarrots
added
the
automerge
|
Oh #12742 💔 |
CriesofCarrots
force-pushed
the
correct-every-bank-timestamp
branch
from
b86110c
to
7562c87
Compare
CriesofCarrots
removed
the
automerge
CriesofCarrots
force-pushed
the
correct-every-bank-timestamp
branch
from
7562c87
to
d46a6e5
Compare
CriesofCarrots
added
the
automerge
mergify bot
pushed a commit
that referenced
this pull request
Oct 9, 2020
* Move timestamp helper to sdk * Add Bank method for getting timestamp estimate * Return sysvar info from Bank::clock * Add feature-gated timestamp correction * Rename unix_timestamp method to be more descriptive * Review comments * Add timestamp metric (cherry picked from commit b028c47) # Conflicts: # runtime/src/feature_set.rs
CriesofCarrots
added a commit
that referenced
this pull request
Oct 9, 2020
* Move timestamp helper to sdk * Add Bank method for getting timestamp estimate * Return sysvar info from Bank::clock * Add feature-gated timestamp correction * Rename unix_timestamp method to be more descriptive * Review comments * Add timestamp metric (cherry picked from commit b028c47) # Conflicts: # runtime/src/feature_set.rs
mergify bot
added a commit
that referenced
this pull request
Oct 10, 2020
* Move timestamp helper to sdk * Add Bank method for getting timestamp estimate * Return sysvar info from Bank::clock * Add feature-gated timestamp correction * Rename unix_timestamp method to be more descriptive * Review comments * Add timestamp metric (cherry picked from commit b028c47) # Conflicts: # runtime/src/feature_set.rs Co-authored-by: Tyera Eulberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The timestamp returned by
Bank::unix_timestamp()ends up in the clock sysvar and is used to assess time-based stake account lockouts. However it's based on a theoretical slots-per-second instead of reality, so it's quite inaccurate. This will pose a problem for lockups, since the accounts will not register as lockup-free on (or anytime near) the date the lockup is set to expire.Block times are estimated using a validator timestamp oracle; this data provides an opportunity to align the bank timestamp more closely with real-world time.
Summary of Changes
Bank::update_clockto set the Clock sysvar timestamp to the stake-weighted timestamp estimate if it is greater than the unix_timestamp from genesis; feature-gatedThis adds 50us to each
Bank::new_from_parent(), which was not distinguishable in confirmation-time or other metrics on a testnet under moderate TPS load.Fixes #9874
Toward #10093 (but requires some additional handling to update Bank::slots_per_year)