Timestamp first vote #11856
Merged
Timestamp first vote #11856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CriesofCarrots
added
the
automerge
|
Thank you! |
mergify
bot
removed
the
automerge
|
automerge label removed due to a CI failure |
CriesofCarrots
force-pushed
the
timestamp-first-slot
branch
from
fbc094e
to
698c9c4
Compare
CriesofCarrots
added
the
automerge
Codecov Report
@@ Coverage Diff @@
## master #11856 +/- ##
=========================================
- Coverage 82.0% 82.0% -0.1%
=========================================
Files 330 330
Lines 77588 77589 +1
=========================================
- Hits 63688 63687 -1
- Misses 13900 13902 +2 |
CriesofCarrots
added a commit
to CriesofCarrots/solana
that referenced
this pull request
Sep 23, 2020
CriesofCarrots
added a commit
that referenced
this pull request
Sep 23, 2020
* Submit a vote timestamp every vote (#10630) * Submit a timestamp for every vote * Submit at most one vote timestamp per second * Submit a timestamp for every new vote Co-authored-by: Tyera Eulberg <[email protected]> * Timestamp first vote (#11856) * Cache block time in Blockstore (#11955) * Add blockstore column to cache block times * Add method to cache block time * Add service to cache block time * Update rpc getBlockTime to use new method, and refactor blockstore slightly * Return block_time with confirmed block, if available * Add measure and warning to cache-block-time Co-authored-by: Michael Vines <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As of #10630, validators are not timestamping their first vote because last_timestamp is initialized at 0 and current_slot == 0. This means that
getBlockTimefails for slot 1, since there are no timestamps before and referring to slot 1.Summary of Changes
self.last_timestamp.slot == 0Fixes #11849
cc @jstarry