Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add confirmed slots to EpochSlots #10246

Closed
wants to merge 3 commits into from

Conversation

carllin
Copy link
Contributor

@carllin carllin commented May 26, 2020

Problem

Dead slots are still marked as complete in ClusterSlots and repaired: #10082

Summary of Changes

Use later half of EpochSlots indexed 128..=255 to hold slots confirmed by the cluster. Confirmed slots are well suited for compression because they are usually monotonically increasing. This way unconfirmed dead slots with errors like InvalidTickCouont need not even attempt to be repaired.

  1. Solves Invalid tick count causes slot dumping #10082
  2. Contributes towards: Repairs can stall on a dead fork #10245
  3. Aids in detecting future duplicate slots that have been confirmed and thus need to be replayed

Fixes #

@carllin carllin added the v1.2 label May 26, 2020
@carllin carllin changed the title Fix cluster slots Add confirmed slots to EpochSlots May 26, 2020
@codecov
Copy link

codecov bot commented May 26, 2020

Codecov Report

Merging #10246 into master will decrease coverage by 0.0%.
The diff coverage is 99.0%.

@@            Coverage Diff            @@
##           master   #10246     +/-   ##
=========================================
- Coverage    81.5%    81.4%   -0.1%     
=========================================
  Files         288      288             
  Lines       66608    66743    +135     
=========================================
+ Hits        54297    54350     +53     
- Misses      12311    12393     +82     

@stale
Copy link

stale bot commented Jun 2, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Jun 2, 2020
@stale
Copy link

stale bot commented Jun 10, 2020

This stale pull request has been automatically closed. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale [bot only] Added to stale content; results in auto-close after a week.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant